Upgrade Development Information and Test Configurations for Go 1.13 #9992
Labels
provider
Pertains to the provider itself, rather than any interaction with AWS.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
Comments
bflad
added
technical-debt
github-actions
bot
added
the
needs-triage
bflad
removed
the
needs-triage
|
|
bflad
added a commit
that referenced
this issue
Sep 23, 2019
Reference: #9992 Reference: #10054 The main change here (and impetus because it seems to use too much memory in Go 1.12 for TravisCI to successfully pass linting) is upgrading github.com/golangci/golangci-lint to v1.18.0, which has fixes for Go 1.13 support in its listed dependencies. It was upgraded via: ```console $ go get github.com/golangci/golangci-lint@v1.18.0 $ go mod tidy $ go mod vendor ``` The addition of `go 1.13` to the `go.mod` file signals that this module should be built with that version of Go or later. Different than Go 1.12, any Go 1.13 command run against the module will always add that versioning information to the go.mod file. We add this once now to prevent unnecessary Git differences in the future. Development, testing, and building with Go 1.12 and earlier should not be affected as we are not introducing any breaking changes at the moment, but we do not officially support versions other than what is tested against via TravisCI. As a simple verification of the above statement: ```console $ go1.12 version go version go1.12.9 darwin/amd64 $ go1.12 test ./... ? github.com/terraform-providers/terraform-provider-aws [no test files] ok github.com/terraform-providers/terraform-provider-aws/aws 1.313s $ go1.12 build $ ``` Passes unit testing, linting, smoke acceptance testing, and release process cross-compilation testing. ```console $ TF_ACC=1 go test ./aws -v -timeout 120m -parallel 20 -run='TestAccAWSProvider' ... --- PASS: TestAccAWSProvider_Region_AwsCommercial (2.58s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.59s) --- PASS: TestAccAWSProvider_Region_AwsChina (2.60s) --- PASS: TestAccAWSProvider_Endpoints_Deprecated (2.72s) --- PASS: TestAccAWSProvider_Endpoints (2.80s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 3.846s $ gox -os='linux darwin windows freebsd openbsd solaris' -arch='386 amd64 arm' -osarch='!darwin/arm !darwin/386' -ldflags '-s -w -X aws/version.ProviderVersion=99.99.99 -X aws/version.ProtocolVersion=4' -output 'results/{{.OS}}_{{.Arch}}/terraform-provider-aws_v99.99.99_x4' . Number of parallel builds: 7 --> darwin/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/amd64: github.com/terraform-providers/terraform-provider-aws --> solaris/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/arm: github.com/terraform-providers/terraform-provider-aws --> windows/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/386: github.com/terraform-providers/terraform-provider-aws --> windows/386: github.com/terraform-providers/terraform-provider-aws --> freebsd/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/arm: github.com/terraform-providers/terraform-provider-aws --> openbsd/386: github.com/terraform-providers/terraform-provider-aws --> openbsd/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/386: github.com/terraform-providers/terraform-provider-aws ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Community Note
Description
Go 1.13 has been released. 🎉
This project typically upgrades its Go version for development and testing shortly after release to get the latest and greatest Go functionality.
Some considerations:
macOS 10.11 is four years old, which seems acceptable to remove in a minor release with a CHANGELOG note.
goxbuilds for all currently supported architecturesgoenvsupport for Go 1.13README.md.travis.ymlCHANGELOG.mdwith note about macOS 10.11 requirementReferences
The text was updated successfully, but these errors were encountered: