provider: Update default development and testing to Go 1.13 #10206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
dependencies
ghost
added
the
Reference: #9992 Reference: #10054 The main change here (and impetus because it seems to use too much memory in Go 1.12 for TravisCI to successfully pass linting) is upgrading github.com/golangci/golangci-lint to v1.18.0, which has fixes for Go 1.13 support in its listed dependencies. It was upgraded via: ```console $ go get github.com/golangci/golangci-lint@v1.18.0 $ go mod tidy $ go mod vendor ``` The addition of `go 1.13` to the `go.mod` file signals that this module should be built with that version of Go or later. Different than Go 1.12, any Go 1.13 command run against the module will always add that versioning information to the go.mod file. We add this once now to prevent unnecessary Git differences in the future. Development, testing, and building with Go 1.12 and earlier should not be affected as we are not introducing any breaking changes at the moment, but we do not officially support versions other than what is tested against via TravisCI. As a simple verification of the above statement: ```console $ go1.12 version go version go1.12.9 darwin/amd64 $ go1.12 test ./... ? github.com/terraform-providers/terraform-provider-aws [no test files] ok github.com/terraform-providers/terraform-provider-aws/aws 1.313s $ go1.12 build $ ``` Passes unit testing, linting, smoke acceptance testing, and release process cross-compilation testing. ```console $ TF_ACC=1 go test ./aws -v -timeout 120m -parallel 20 -run='TestAccAWSProvider' ... --- PASS: TestAccAWSProvider_Region_AwsCommercial (2.58s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.59s) --- PASS: TestAccAWSProvider_Region_AwsChina (2.60s) --- PASS: TestAccAWSProvider_Endpoints_Deprecated (2.72s) --- PASS: TestAccAWSProvider_Endpoints (2.80s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 3.846s $ gox -os='linux darwin windows freebsd openbsd solaris' -arch='386 amd64 arm' -osarch='!darwin/arm !darwin/386' -ldflags '-s -w -X aws/version.ProviderVersion=99.99.99 -X aws/version.ProtocolVersion=4' -output 'results/{{.OS}}_{{.Arch}}/terraform-provider-aws_v99.99.99_x4' . Number of parallel builds: 7 --> darwin/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/amd64: github.com/terraform-providers/terraform-provider-aws --> solaris/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/arm: github.com/terraform-providers/terraform-provider-aws --> windows/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/386: github.com/terraform-providers/terraform-provider-aws --> windows/386: github.com/terraform-providers/terraform-provider-aws --> freebsd/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/arm: github.com/terraform-providers/terraform-provider-aws --> openbsd/386: github.com/terraform-providers/terraform-provider-aws --> openbsd/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/386: github.com/terraform-providers/terraform-provider-aws ```
1 task
|
This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #9992
Closes #10054
Release note for CHANGELOG:
The main change here (and impetus because it seems to use too much memory in Go 1.12 for TravisCI to successfully pass linting) is upgrading github.com/golangci/golangci-lint to v1.18.0, which has fixes for Go 1.13 support in its listed dependencies. It was upgraded via:
The addition of
go 1.13to thego.modfile signals that this module should be built with that version of Go or later. Different than Go 1.12, any Go 1.13 command run against the module will always add that versioning information to the go.mod file. We add this once now to prevent unnecessary Git differences in the future. Development, testing, and building with Go 1.12 and earlier should not be affected as we are not introducing any breaking changes at the moment, but we do not officially support versions other than what is tested against via TravisCI.As a simple verification of the above statement:
Passes unit testing, linting, smoke acceptance testing, and release process cross-compilation testing.