Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_wafregional_web_acl_association: Ensure missing resource triggers state removal #10216

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 24, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9203

Release note for CHANGELOG:

resource/aws_wafregional_web_acl_association: Ensure missing resource triggers state removal

Previous to code change:

--- FAIL: TestAccAWSWafRegionalWebAclAssociation_disappears (175.64s)
    testing.go:569: Step 0 error: errors during follow-up refresh:

        Error: error getting WAF Regional Web ACL for resource (arn:aws:elasticloadbalancing:us-west-2:--OMITTED--:loadbalancer/app/tf-lb-20190924095723723200000001/e2739f0d448dc712): empty response

Output from acceptance testing:

--- PASS: TestAccAWSWafRegionalWebAclAssociation_disappears (207.92s)

… triggers state removal

Reference: #9203

Previous to code change:

```
--- FAIL: TestAccAWSWafRegionalWebAclAssociation_disappears (175.64s)
    testing.go:569: Step 0 error: errors during follow-up refresh:

        Error: error getting WAF Regional Web ACL for resource (arn:aws:elasticloadbalancing:us-west-2:--OMITTED--:loadbalancer/app/tf-lb-20190924095723723200000001/e2739f0d448dc712): empty response
```

Output from acceptance testing:

```
--- PASS: TestAccAWSWafRegionalWebAclAssociation_disappears (207.92s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service. labels Sep 24, 2019
@bflad bflad requested a review from a team September 24, 2019 10:10
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 24, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bflad bflad added this to the v2.31.0 milestone Sep 30, 2019
@bflad bflad merged commit bcc476b into master Sep 30, 2019
@bflad bflad deleted the b-aws_wafregional_web_acl_association-disappears branch September 30, 2019 17:42
bflad added a commit that referenced this pull request Sep 30, 2019
@ghost
Copy link

ghost commented Oct 3, 2019

This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error getting WAF Regional Web ACL for resource (<api gw stage arn>): empty response
2 participants