Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/aws_rds_cluster: Refactor tagging to use keyvaluetags library #10724

Merged
merged 4 commits into from
Nov 4, 2019
Merged

data/aws_rds_cluster: Refactor tagging to use keyvaluetags library #10724

merged 4 commits into from
Nov 4, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAWSRDSCluster_'

--- PASS: TestAccDataSourceAWSRDSCluster_basic (198.72s)
...

@DrFaust92 DrFaust92 requested a review from a team November 2, 2019 11:53
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. labels Nov 2, 2019
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 4, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 4, 2019
bflad
bflad approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

--- PASS: TestAccDataSourceAWSRDSCluster_basic (134.99s)

aws/data_source_aws_rds_cluster.go
// Fetch and save tags
if err := saveTagsRDS(conn, d, aws.StringValue(dbc.DBClusterArn)); err != nil {
log.Printf("[WARN] Failed to save tags for RDS Cluster (%s): %s", aws.StringValue(dbc.DBClusterIdentifier), err)
tags, err := keyvaluetags.RdsListTags(conn, *arn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: To prevent potential panics, we generally recommend using the AWS Go SDK provided conversion functions to dereference pointers, e.g. aws.StringValue(dbc.DBClusterArn) above

@bflad bflad merged commit 3d37901 into hashicorp:master Nov 4, 2019
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the data-rds-cluster-keyvaluetags branch November 9, 2019 12:40
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrFaust92 @bflad