-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data/aws_rds_cluster: Refactor tagging to use keyvaluetags library #10724
data/aws_rds_cluster: Refactor tagging to use keyvaluetags library #10724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @DrFaust92 🚀
--- PASS: TestAccDataSourceAWSRDSCluster_basic (134.99s)
// Fetch and save tags | ||
if err := saveTagsRDS(conn, d, aws.StringValue(dbc.DBClusterArn)); err != nil { | ||
log.Printf("[WARN] Failed to save tags for RDS Cluster (%s): %s", aws.StringValue(dbc.DBClusterIdentifier), err) | ||
tags, err := keyvaluetags.RdsListTags(conn, *arn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: To prevent potential panics, we generally recommend using the AWS Go SDK provided conversion functions to dereference pointers, e.g. aws.StringValue(dbc.DBClusterArn)
above
This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #10688
Release note for CHANGELOG:
Output from acceptance testing: