r/aws_route_table: Various fixes #14543

ewbankkit · 2020-08-10T16:09:53Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #14531.
Relates: #15490.

Uses additional tests cases from #14013.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

TODO

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_basic -timeout 120m === RUN TestAccAWSRouteTable_basic === PAUSE TestAccAWSRouteTable_basic === CONT TestAccAWSRouteTable_basic --- PASS: TestAccAWSRouteTable_basic (37.78s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 37.839s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_disappears -timeout 120m === RUN TestAccAWSRouteTable_disappears === PAUSE TestAccAWSRouteTable_disappears === CONT TestAccAWSRouteTable_disappears --- PASS: TestAccAWSRouteTable_disappears (35.58s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 35.625s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv4_To_InternetGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv4_To_InternetGateway -timeout 120m === RUN TestAccAWSRouteTable_IPv4_To_InternetGateway === PAUSE TestAccAWSRouteTable_IPv4_To_InternetGateway === CONT TestAccAWSRouteTable_IPv4_To_InternetGateway --- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (78.31s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 78.372s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_tags' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_tags -timeout 120m === RUN TestAccAWSRouteTable_tags === PAUSE TestAccAWSRouteTable_tags === CONT TestAccAWSRouteTable_tags --- PASS: TestAccAWSRouteTable_tags (84.18s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 84.234s

…eTable_IPv4_To_Instance'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv4_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv4_To_Instance -timeout 120m === RUN TestAccAWSRouteTable_IPv4_To_Instance === PAUSE TestAccAWSRouteTable_IPv4_To_Instance === CONT TestAccAWSRouteTable_IPv4_To_Instance --- PASS: TestAccAWSRouteTable_IPv4_To_Instance (109.73s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 109.799s

…le_IPv6_To_EgressOnlyInternetGateway'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway -timeout 120m === RUN TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === CONT TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (41.79s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 41.826s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_panicEmptyRoute' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_panicEmptyRoute -timeout 120m === RUN TestAccAWSRouteTable_panicEmptyRoute === PAUSE TestAccAWSRouteTable_panicEmptyRoute === CONT TestAccAWSRouteTable_panicEmptyRoute --- PASS: TestAccAWSRouteTable_panicEmptyRoute (24.60s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 24.636s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_Route_ConfigMode' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_Route_ConfigMode -timeout 120m === RUN TestAccAWSRouteTable_Route_ConfigMode === PAUSE TestAccAWSRouteTable_Route_ConfigMode === CONT TestAccAWSRouteTable_Route_ConfigMode --- PASS: TestAccAWSRouteTable_Route_ConfigMode (102.67s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 102.732s

…TestAccAWSRouteTable_IPv4_To_TransitGateway'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv4_To_TransitGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv4_To_TransitGateway -timeout 120m === RUN TestAccAWSRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSRouteTable_IPv4_To_TransitGateway === CONT TestAccAWSRouteTable_IPv4_To_TransitGateway --- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (338.85s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 338.907s

…uteTable_IPv4_To_VpcPeeringConnection'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection -timeout 120m === RUN TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === CONT TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (43.87s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 43.905s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_vgwRoutePropagation' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_vgwRoutePropagation -timeout 120m === RUN TestAccAWSRouteTable_vgwRoutePropagation === PAUSE TestAccAWSRouteTable_vgwRoutePropagation === CONT TestAccAWSRouteTable_vgwRoutePropagation --- PASS: TestAccAWSRouteTable_vgwRoutePropagation (112.21s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 112.290s

…ointAssociation'. Currently fails. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_VpcMultipleCidrs_VpcEndpointAssociation' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_VpcMultipleCidrs_VpcEndpointAssociation -timeout 120m === RUN TestAccAWSRouteTable_VpcMultipleCidrs_VpcEndpointAssociation === PAUSE TestAccAWSRouteTable_VpcMultipleCidrs_VpcEndpointAssociation === CONT TestAccAWSRouteTable_VpcMultipleCidrs_VpcEndpointAssociation --- FAIL: TestAccAWSRouteTable_VpcMultipleCidrs_VpcEndpointAssociation (47.64s) testing.go:684: Step 0 error: Check failed: Check 2/7 error: Route Table has incorrect number of routes (Expected=3, Actual=2) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 47.694s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1

…tion'.

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv4_To_NatGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv4_To_NatGateway -timeout 120m === RUN TestAccAWSRouteTable_IPv4_To_NatGateway === PAUSE TestAccAWSRouteTable_IPv4_To_NatGateway === CONT TestAccAWSRouteTable_IPv4_To_NatGateway --- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (228.80s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 228.838s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv6_To_NetworkInterface' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv6_To_NetworkInterface -timeout 120m === RUN TestAccAWSRouteTable_IPv6_To_NetworkInterface === PAUSE TestAccAWSRouteTable_IPv6_To_NetworkInterface === CONT TestAccAWSRouteTable_IPv6_To_NetworkInterface --- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface (48.88s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 48.917s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_ConditionalCidrBlock' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_ConditionalCidrBlock -timeout 120m === RUN TestAccAWSRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSRouteTable_ConditionalCidrBlock === CONT TestAccAWSRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (78.76s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 78.837s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_vgwRoutePropagation' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_vgwRoutePropagation -timeout 120m === RUN TestAccAWSRouteTable_vgwRoutePropagation === PAUSE TestAccAWSRouteTable_vgwRoutePropagation === CONT TestAccAWSRouteTable_vgwRoutePropagation --- PASS: TestAccAWSRouteTable_vgwRoutePropagation (115.39s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 115.474s

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRouteTable_ -timeout 120m === RUN TestAccAWSRouteTable_basic === PAUSE TestAccAWSRouteTable_basic === RUN TestAccAWSRouteTable_disappears === PAUSE TestAccAWSRouteTable_disappears === RUN TestAccAWSRouteTable_IPv4_To_InternetGateway === PAUSE TestAccAWSRouteTable_IPv4_To_InternetGateway === RUN TestAccAWSRouteTable_IPv4_To_Instance === PAUSE TestAccAWSRouteTable_IPv4_To_Instance === RUN TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRouteTable_tags === PAUSE TestAccAWSRouteTable_tags === RUN TestAccAWSRouteTable_panicEmptyRoute === PAUSE TestAccAWSRouteTable_panicEmptyRoute === RUN TestAccAWSRouteTable_Route_ConfigMode === PAUSE TestAccAWSRouteTable_Route_ConfigMode === RUN TestAccAWSRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSRouteTable_IPv4_To_TransitGateway === RUN TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRouteTable_vgwRoutePropagation === PAUSE TestAccAWSRouteTable_vgwRoutePropagation === RUN TestAccAWSRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSRouteTable_ConditionalCidrBlock === RUN TestAccAWSRouteTable_IPv4_To_NatGateway === PAUSE TestAccAWSRouteTable_IPv4_To_NatGateway === RUN TestAccAWSRouteTable_IPv6_To_NetworkInterface === PAUSE TestAccAWSRouteTable_IPv6_To_NetworkInterface === CONT TestAccAWSRouteTable_basic === CONT TestAccAWSRouteTable_IPv4_To_TransitGateway --- PASS: TestAccAWSRouteTable_basic (37.06s) === CONT TestAccAWSRouteTable_IPv6_To_NetworkInterface --- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface (47.79s) === CONT TestAccAWSRouteTable_IPv4_To_NatGateway --- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (196.98s) === CONT TestAccAWSRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (348.59s) === CONT TestAccAWSRouteTable_vgwRoutePropagation --- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (77.19s) === CONT TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (44.68s) === CONT TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (42.42s) === CONT TestAccAWSRouteTable_Route_ConfigMode --- PASS: TestAccAWSRouteTable_vgwRoutePropagation (115.86s) === CONT TestAccAWSRouteTable_panicEmptyRoute --- PASS: TestAccAWSRouteTable_panicEmptyRoute (24.55s) === CONT TestAccAWSRouteTable_tags --- PASS: TestAccAWSRouteTable_Route_ConfigMode (101.57s) === CONT TestAccAWSRouteTable_IPv4_To_InternetGateway --- PASS: TestAccAWSRouteTable_tags (83.12s) === CONT TestAccAWSRouteTable_IPv4_To_Instance --- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (78.17s) === CONT TestAccAWSRouteTable_disappears --- PASS: TestAccAWSRouteTable_disappears (34.81s) --- PASS: TestAccAWSRouteTable_IPv4_To_Instance (121.04s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 693.250s

…o_NetworkInterface_Attached' and 'TestAccAWSRouteTable_IPv4_To_NetworkInterface_TwoAttachments'. These two tests fail as expected (#1426 and hashicorp#5745).

…ndpointAssociation' to 'TestAccAWSRouteTable_VpcMultipleCidrs'. Gateway VPC Endpoint routes are added asynchronously so don't attempt to test. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_VpcMultipleCidrs' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_VpcMultipleCidrs -timeout 120m === RUN TestAccAWSRouteTable_VpcMultipleCidrs === PAUSE TestAccAWSRouteTable_VpcMultipleCidrs === CONT TestAccAWSRouteTable_VpcMultipleCidrs --- PASS: TestAccAWSRouteTable_VpcMultipleCidrs (62.16s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 62.213s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_VpcClassicLink' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_VpcClassicLink -timeout 120m === RUN TestAccAWSRouteTable_VpcClassicLink === PAUSE TestAccAWSRouteTable_VpcClassicLink === CONT TestAccAWSRouteTable_VpcClassicLink --- PASS: TestAccAWSRouteTable_VpcClassicLink (38.84s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 38.888s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_GatewayVpcEndpoint' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_GatewayVpcEndpoint -timeout 120m === RUN TestAccAWSRouteTable_GatewayVpcEndpoint === PAUSE TestAccAWSRouteTable_GatewayVpcEndpoint === CONT TestAccAWSRouteTable_GatewayVpcEndpoint --- PASS: TestAccAWSRouteTable_GatewayVpcEndpoint (210.60s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 210.650s

…tion'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_disappears_SubnetAssociation' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_disappears_SubnetAssociation -timeout 120m === RUN TestAccAWSRouteTable_disappears_SubnetAssociation === PAUSE TestAccAWSRouteTable_disappears_SubnetAssociation === CONT TestAccAWSRouteTable_disappears_SubnetAssociation --- PASS: TestAccAWSRouteTable_disappears_SubnetAssociation (44.11s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 44.160s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_MultipleRoutes' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_MultipleRoutes -timeout 120m === RUN TestAccAWSRouteTable_MultipleRoutes === PAUSE TestAccAWSRouteTable_MultipleRoutes === CONT TestAccAWSRouteTable_MultipleRoutes --- PASS: TestAccAWSRouteTable_MultipleRoutes (191.08s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 191.139s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv4_To_Instance' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv4_To_Instance -timeout 120m === RUN TestAccAWSRouteTable_IPv4_To_Instance === PAUSE TestAccAWSRouteTable_IPv4_To_Instance === CONT TestAccAWSRouteTable_IPv4_To_Instance --- PASS: TestAccAWSRouteTable_IPv4_To_Instance (109.91s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 110.478s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_MultipleRoutes' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_MultipleRoutes -timeout 120m === RUN TestAccAWSRouteTable_MultipleRoutes === PAUSE TestAccAWSRouteTable_MultipleRoutes === CONT TestAccAWSRouteTable_MultipleRoutes --- PASS: TestAccAWSRouteTable_MultipleRoutes (204.15s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 204.201s

…ace_Attached' and 'TestAccAWSRouteTable_IPv4_To_NetworkInterface_TwoAttachments'. If we mark `instance_id` and `network_interface_id` as both `Computed: true` in the `route` attribute's schema then we end up having to change the associated set hash function to choose one or other of those attributes to include in the hash and ignore the other. This means that either 'TestAccAWSRouteTable_IPv4_To_Instance' will show continuous diffs or 'TestAccAWSRouteTable_IPv4_To_NetworkInterface_Attached' will. The longer term solution is to remove `instance_id` as a route target as the instance's primary ENI's ID can be used in the `network_interface_id`. This will also simplify the `aws_route` resource.

…ck is used. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway -timeout 120m === RUN TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === CONT TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (60.43s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 60.474s

… Add functions to 'aws/internal/service/ec2/finder' and 'aws/internal/service/ec2/waiter'.

… and 'aws/internal/service/ec2/waiter'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_basic -timeout 120m === RUN TestAccAWSRouteTable_basic === PAUSE TestAccAWSRouteTable_basic === CONT TestAccAWSRouteTable_basic --- PASS: TestAccAWSRouteTable_basic (38.43s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 38.479s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_disappears -timeout 120m === RUN TestAccAWSRouteTable_disappears === PAUSE TestAccAWSRouteTable_disappears === CONT TestAccAWSRouteTable_disappears --- PASS: TestAccAWSRouteTable_disappears (34.41s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 34.472s

…Func. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_basic -timeout 120m === RUN TestAccAWSRouteTable_basic === PAUSE TestAccAWSRouteTable_basic === CONT TestAccAWSRouteTable_basic --- PASS: TestAccAWSRouteTable_basic (36.49s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 36.542s

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteTable_ -timeout 120m === RUN TestAccAWSRouteTable_basic === PAUSE TestAccAWSRouteTable_basic === RUN TestAccAWSRouteTable_disappears === PAUSE TestAccAWSRouteTable_disappears === RUN TestAccAWSRouteTable_disappears_SubnetAssociation === PAUSE TestAccAWSRouteTable_disappears_SubnetAssociation === RUN TestAccAWSRouteTable_IPv4_To_InternetGateway === PAUSE TestAccAWSRouteTable_IPv4_To_InternetGateway === RUN TestAccAWSRouteTable_IPv4_To_Instance === PAUSE TestAccAWSRouteTable_IPv4_To_Instance === RUN TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRouteTable_tags === PAUSE TestAccAWSRouteTable_tags === RUN TestAccAWSRouteTable_panicEmptyRoute === PAUSE TestAccAWSRouteTable_panicEmptyRoute === RUN TestAccAWSRouteTable_Route_ConfigMode === PAUSE TestAccAWSRouteTable_Route_ConfigMode === RUN TestAccAWSRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSRouteTable_IPv4_To_TransitGateway === RUN TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRouteTable_vgwRoutePropagation === PAUSE TestAccAWSRouteTable_vgwRoutePropagation === RUN TestAccAWSRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSRouteTable_ConditionalCidrBlock === RUN TestAccAWSRouteTable_IPv4_To_NatGateway === PAUSE TestAccAWSRouteTable_IPv4_To_NatGateway === RUN TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRouteTable_VpcMultipleCidrs === PAUSE TestAccAWSRouteTable_VpcMultipleCidrs === RUN TestAccAWSRouteTable_VpcClassicLink === PAUSE TestAccAWSRouteTable_VpcClassicLink === RUN TestAccAWSRouteTable_GatewayVpcEndpoint === PAUSE TestAccAWSRouteTable_GatewayVpcEndpoint === RUN TestAccAWSRouteTable_MultipleRoutes === PAUSE TestAccAWSRouteTable_MultipleRoutes === CONT TestAccAWSRouteTable_basic === CONT TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRouteTable_basic (26.84s) === CONT TestAccAWSRouteTable_MultipleRoutes --- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (33.24s) === CONT TestAccAWSRouteTable_GatewayVpcEndpoint --- PASS: TestAccAWSRouteTable_GatewayVpcEndpoint (43.50s) === CONT TestAccAWSRouteTable_VpcClassicLink --- PASS: TestAccAWSRouteTable_VpcClassicLink (26.90s) === CONT TestAccAWSRouteTable_VpcMultipleCidrs --- PASS: TestAccAWSRouteTable_VpcMultipleCidrs (50.50s) === CONT TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached (36.25s) === CONT TestAccAWSRouteTable_IPv4_To_NatGateway --- PASS: TestAccAWSRouteTable_MultipleRoutes (181.09s) === CONT TestAccAWSRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (58.15s) === CONT TestAccAWSRouteTable_vgwRoutePropagation --- PASS: TestAccAWSRouteTable_vgwRoutePropagation (102.03s) === CONT TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (195.58s) === CONT TestAccAWSRouteTable_IPv4_To_TransitGateway --- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (43.63s) === CONT TestAccAWSRouteTable_Route_ConfigMode --- PASS: TestAccAWSRouteTable_Route_ConfigMode (73.39s) === CONT TestAccAWSRouteTable_panicEmptyRoute --- PASS: TestAccAWSRouteTable_panicEmptyRoute (18.37s) === CONT TestAccAWSRouteTable_tags --- PASS: TestAccAWSRouteTable_tags (57.43s) === CONT TestAccAWSRouteTable_IPv4_To_InternetGateway --- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (59.27s) === CONT TestAccAWSRouteTable_IPv4_To_Instance --- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (335.84s) === CONT TestAccAWSRouteTable_disappears_SubnetAssociation --- PASS: TestAccAWSRouteTable_IPv4_To_Instance (121.95s) === CONT TestAccAWSRouteTable_disappears --- PASS: TestAccAWSRouteTable_disappears_SubnetAssociation (31.51s) --- PASS: TestAccAWSRouteTable_disappears (23.83s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 766.048s

ewbankkit · 2020-08-21T19:36:49Z

TODO

Don't attempt to reuse schema with aws_default_route_table - see #14642.
Add arn attribute?

ghost · 2020-11-18T17:10:01Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit added 30 commits August 8, 2020 17:43

Comment out 'TestAccAWSRouteTable_VpcMultipleCidrs_VpcEndpointAssocia…

e95fd81

…tion'.

r/aws_route_table: Add (and comment out) 'TestAccAWSRouteTable_IPv4_T…

f6e88cc

…o_NetworkInterface_Attached' and 'TestAccAWSRouteTable_IPv4_To_NetworkInterface_TwoAttachments'. These two tests fail as expected (#1426 and hashicorp#5745).

r/aws_route_table: Add 'testAccCheckAWSRouteTableRoute'.

f85fdeb

r/aws_route_table: Use 'testAccAvailableAZsNoOptInExcludeConfig'.

6f12ba9

Use 'testAccAvailableAZsNoOptInDefaultExcludeConfig'.

037b7b4

ewbankkit added 6 commits August 10, 2020 11:41

Add 'routeTableRouteSchema' for shared schema.

8cabea0

r/aws_route_table: Add error constants to 'aws/internal/service/ec2'.…

c388f39

… Add functions to 'aws/internal/service/ec2/finder' and 'aws/internal/service/ec2/waiter'.

r/aws_route_table: Read, not Update, after Create (hashicorp#12998).

e3c1142

ewbankkit requested a review from a team August 10, 2020 16:09

ghost added size/XXL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 10, 2020

ewbankkit mentioned this pull request Aug 26, 2020

aws_ec2_transit_gateway_route: cidr match is unreliable #14846

Merged

thekev pushed a commit to thekev/terraform-provider-aws that referenced this pull request Aug 26, 2020

use canonicalCidrBlock() from hashicorp#14543

bd0020b

ewbankkit changed the title ~~[WIP] r/aws_route_table: Various fixes~~ r/aws_route_table: Various fixes Oct 18, 2020

ewbankkit closed this Oct 18, 2020

ewbankkit deleted the b-various-aws_route_table-fixes-redux branch October 18, 2020 22:18

ghost locked as resolved and limited conversation to collaborators Nov 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_route_table: Various fixes #14543

r/aws_route_table: Various fixes #14543

ewbankkit commented Aug 10, 2020 •

edited

Loading

ewbankkit commented Aug 21, 2020 •

edited

Loading

ghost commented Nov 18, 2020

r/aws_route_table: Various fixes #14543

r/aws_route_table: Various fixes #14543

Conversation

ewbankkit commented Aug 10, 2020 • edited Loading

Community Note

ewbankkit commented Aug 21, 2020 • edited Loading

TODO

ghost commented Nov 18, 2020

ewbankkit commented Aug 10, 2020 •

edited

Loading

ewbankkit commented Aug 21, 2020 •

edited

Loading