Ignore/Fix and Enable tfproviderlint R018 Check for time.Sleep() Usage

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The tfproviderlint R018 check was recently released:

The R018 analyzer reports time.Sleep() function usage. Terraform Providers should generally avoid this function when waiting for API operations and prefer polling methods such as resource.Retry() or (resource.StateChangeConf).WaitForState().

Existing Reports

• aws/resource_aws_ec2_fleet_test.go
• aws/resource_aws_lightsail_instance_test.go
• aws/resource_aws_opsworks_stack.go
• aws/resource_aws_route_table.go
• aws/resource_aws_s3_account_public_access_block_test.go
• aws/resource_aws_spot_fleet_request_test.go

Definition of Done

• Preferably fix or otherwise ignore existing reports
• R018 check added to Makefile awsproviderlint target and CI passes

References

• tfproviderlint R018 Check

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.