Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GuardDuty filter resource #14876

Merged
merged 70 commits into from Sep 2, 2020
Merged

Add GuardDuty filter resource #14876

Show file tree
Hide file tree
Changes from 69 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
dd41a64
Merge pull request #2 from terraform-providers/master
graffzon Jul 7, 2020
af118c7
Added a partially copied, partially corrected resource file
Sep 2, 2019
70d99dd
Fixed or workarounded syntax errors
Sep 3, 2019
622fe20
Made Create action uncommented and not crashing
Sep 3, 2019
8852d14
Made Create action to make its way to the API request
Sep 4, 2019
6f7535a
Added tags field for creation
Sep 11, 2019
17e3fb4
Fixed tags assignment
Sep 11, 2019
7f22a94
Made create request work for region only condition
Sep 11, 2019
fc29555
Implemented DELETE action for filters
Sep 11, 2019
031b0f1
Filled in finding criteria
Sep 12, 2019
e912469
Extracted buildFindingCriteria
Oct 14, 2019
7df19eb
Changed the format of guard_duty_filter criterion
Oct 14, 2019
fb5db6f
Made different sort of conditions work
Oct 14, 2019
c8b3284
Added the update action for the guardduty filter
Oct 22, 2019
4dfc52c
Cleaned up the action default and unveiled the update action
Oct 23, 2019
f990e1e
Added validations for generic cases
Oct 23, 2019
2fa228f
Implemented on-the-flight validation for the conditions
Oct 23, 2019
bdba53c
Cleaned up comments
Oct 23, 2019
fd81374
Made Id of GD filter to be a compounded one
Oct 24, 2019
34c8630
Moved a function
Oct 24, 2019
08b50a8
Added import function without the findingCriteria
Oct 28, 2019
db2daeb
Gofmt fixes
Oct 28, 2019
bc4ac65
Gofmt with -s fixes
Oct 28, 2019
c241f37
Implemented a mock of flattening of the finding criteria
Oct 28, 2019
d4b07c2
Fixed map with possible conditions
Oct 28, 2019
d6e6608
Made import work also for Finding Criteria
Oct 28, 2019
73a737e
Dryed up the flattening functions
Oct 28, 2019
7432698
Just moved things around
Oct 28, 2019
2821f87
Fixed create/update case where one field can contain more than one co…
Oct 28, 2019
de0c9b5
Implemented a better error output
Oct 28, 2019
4d10921
Added tests for GuardDuty filter
Oct 29, 2019
124db85
Improved tests
Oct 29, 2019
f08993c
Added the documentation
Oct 29, 2019
88a5e3a
Tiny stylefix
Oct 29, 2019
5678e3f
Updated the resource to work with the new provider version
Oct 30, 2019
9b3fdb4
Removed obsolete tests cases
graffzon Oct 31, 2019
a33fa1e
Add the subcategory "GuardDuty"
suzuki-shunsuke Jun 29, 2020
88da720
Add a validator for a minimum length of 3, maximum length of 64
suzuki-shunsuke Jun 29, 2020
a6c803c
Add a validator for a maximum length of 512
suzuki-shunsuke Jun 29, 2020
771b217
Use keyvaluetags package
suzuki-shunsuke Jun 29, 2020
f08db23
Update the fmt.Errorf calls to return the error object itself using t…
suzuki-shunsuke Jun 29, 2020
3c15feb
Rephrase an error message
suzuki-shunsuke Jun 29, 2020
647492a
Add test to cover updating values
suzuki-shunsuke Jun 30, 2020
958a39f
Use resource.TestCheckResourceAttrPair to verify that the correct val…
suzuki-shunsuke Jun 30, 2020
e8792bf
Add test for finding_criteria
suzuki-shunsuke Jun 30, 2020
a2885f2
Fix a lint error AWSR002
graffzon Jul 7, 2020
7da9ed3
Remove deprecated 'sidebar_current'
graffzon Jul 7, 2020
d48e8ce
Update aws/resource_aws_guardduty_filter.go
gdavison Aug 11, 2020
b0c158e
Remove the timeout setting
suzuki-shunsuke Jul 16, 2020
0199cf6
Fix the error handling
suzuki-shunsuke Jul 16, 2020
07490bf
Fix the error handling
suzuki-shunsuke Jul 16, 2020
c4df914
Fix the error handling
suzuki-shunsuke Jul 16, 2020
cab69c1
Replace strings to constants defined in the AWS SDK
suzuki-shunsuke Jul 16, 2020
045fb77
Fix the style in document
suzuki-shunsuke Jul 16, 2020
9094964
Simplify flattenFindingCriteria
suzuki-shunsuke Jul 17, 2020
5db310e
Change pointer
suzuki-shunsuke Jul 17, 2020
fbcd71a
Check for too many parts as well
suzuki-shunsuke Jul 17, 2020
a120a04
Make test data simple and move the resource under test to the top of …
suzuki-shunsuke Jul 17, 2020
672d35f
Use parseImportedId
suzuki-shunsuke Jul 19, 2020
88ea72d
Define the function to create the GuardDuty Filter's ID
suzuki-shunsuke Jul 19, 2020
87638fe
Use aws.StringValue instead of direct pointer manupulation
suzuki-shunsuke Jul 19, 2020
e313e2b
Add a variable detectorResourceName
suzuki-shunsuke Jul 21, 2020
c5486f8
Merge branch 'master' into added-guardduty-filter-resource
gdavison Aug 26, 2020
a001f20
Handle case when there are no tags set and add more complete tests
gdavison Aug 26, 2020
508424d
Adds update and disappears tests
gdavison Aug 27, 2020
619c9e5
Adds tag update ability and ARN output
gdavison Aug 27, 2020
2213310
Updates Exists function to make API call and return API object
gdavison Aug 27, 2020
bc43990
Updates filter criteria to match AWS API
gdavison Aug 28, 2020
54ab4ff
Uses RFC 3339 dates for "updatedAt" field
gdavison Aug 31, 2020
9c8eaf2
Updates from code review
gdavison Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion aws/provider.go
View file
Open in desktop
Expand Up @@ -626,12 +626,13 @@ func Provider() *schema.Provider {
"aws_glue_trigger": resourceAwsGlueTrigger(),
"aws_glue_workflow": resourceAwsGlueWorkflow(),
"aws_guardduty_detector": resourceAwsGuardDutyDetector(),
"aws_guardduty_publishing_destination": resourceAwsGuardDutyPublishingDestination(),
"aws_guardduty_filter": resourceAwsGuardDutyFilter(),
"aws_guardduty_invite_accepter": resourceAwsGuardDutyInviteAccepter(),
"aws_guardduty_ipset": resourceAwsGuardDutyIpset(),
"aws_guardduty_member": resourceAwsGuardDutyMember(),
"aws_guardduty_organization_admin_account": resourceAwsGuardDutyOrganizationAdminAccount(),
"aws_guardduty_organization_configuration": resourceAwsGuardDutyOrganizationConfiguration(),
"aws_guardduty_publishing_destination": resourceAwsGuardDutyPublishingDestination(),
"aws_guardduty_threatintelset": resourceAwsGuardDutyThreatintelset(),
"aws_iam_access_key": resourceAwsIamAccessKey(),
"aws_iam_account_alias": resourceAwsIamAccountAlias(),
Expand Down