Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/service/rds: Remove hardcoded instance classes from EC2-Classic tests and basic data source test #15184

Merged
merged 1 commit into from
Sep 17, 2020
Merged

tests/service/rds: Remove hardcoded instance classes from EC2-Classic tests and basic data source test #15184

merged 1 commit into from
Sep 17, 2020

Conversation

bflad
Copy link
Member

@bflad bflad commented Sep 16, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15182

Release note for CHANGELOG:

NONE

Previously:

=== CONT  TestAccAWSDBInstance_ec2Classic
TestAccAWSDBInstance_ec2Classic: resource_aws_db_instance_test.go:2248: Step 1/1 error: terraform failed: exit status 1
stderr:
Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time.
  status code: 400, request id: 5bc39058-0571-4f63-bb80-c25533285646
--- FAIL: TestAccAWSDBInstance_ec2Classic (5.31s)

=== CONT  TestAccAWSDbInstanceDataSource_ec2Classic
TestAccAWSDbInstanceDataSource_ec2Classic: data_source_aws_db_instance_test.go:51: Step 1/1 error: terraform failed: exit status 1
stderr:
Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time.
  status code: 400, request id: 38414095-00df-4a5d-ba25-241b5c400ef6
--- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (15.24s)

Output from acceptance testing:

--- PASS: TestAccAWSDbInstanceDataSource_basic (617.92s)
--- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (456.35s)

--- PASS: TestAccAWSDBInstance_ec2Classic (406.18s)

@bflad
tests/service/rds: Remove hardcoded instance classes from EC2-Classic…
b60e2c4 
… tests and basic data source test

Reference: #15182

Previously:

```
=== CONT  TestAccAWSDBInstance_ec2Classic
TestAccAWSDBInstance_ec2Classic: resource_aws_db_instance_test.go:2248: Step 1/1 error: terraform failed: exit status 1
stderr:
Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time.
  status code: 400, request id: 5bc39058-0571-4f63-bb80-c25533285646
--- FAIL: TestAccAWSDBInstance_ec2Classic (5.31s)

=== CONT  TestAccAWSDbInstanceDataSource_ec2Classic
TestAccAWSDbInstanceDataSource_ec2Classic: data_source_aws_db_instance_test.go:51: Step 1/1 error: terraform failed: exit status 1
stderr:
Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time.
  status code: 400, request id: 38414095-00df-4a5d-ba25-241b5c400ef6
--- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (15.24s)
```

Output from acceptance testing:

```
--- PASS: TestAccAWSDbInstanceDataSource_basic (617.92s)
--- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (456.35s)

--- PASS: TestAccAWSDBInstance_ec2Classic (406.18s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Sep 16, 2020
@bflad bflad requested a review from a team September 16, 2020 17:48
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 16, 2020
@YakDriver YakDriver self-assigned this Sep 17, 2020
@YakDriver
Copy link
Member

YakDriver commented Sep 17, 2020 •
edited

The output from acceptance testing on GovCloud (failures are unrelated to this change, see #14778):

--- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (1.08s)
--- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (2.07s)
--- FAIL: TestAccAWSDBInstance_subnetGroup (16.15s)
--- PASS: TestAccAWSDBInstance_iamAuth (452.25s)
--- PASS: TestAccAWSDBInstance_kmsKey (494.49s)
--- PASS: TestAccAWSDBInstance_basic (505.38s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (507.30s)
--- PASS: TestAccAWSDBInstance_generatedName (514.09s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (526.66s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (530.86s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (549.99s)
--- PASS: TestAccAWSDBInstance_namePrefix (554.08s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (9.49s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (0.45s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (9.53s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- PASS: TestAccAWSDBInstance_optionGroup (585.42s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (594.69s)
--- PASS: TestAccAWSDbInstanceDataSource_basic (608.48s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (595.71s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (612.74s)
--- PASS: TestAccAWSDBInstance_Password (465.16s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (968.97s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1280.50s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1311.45s)
--- FAIL: TestAccAWSDBInstance_S3Import (4.52s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1391.97s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1402.12s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1463.54s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1442.81s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1513.94s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1585.49s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1595.55s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1544.27s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1563.78s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1685.31s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (0.62s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1301.59s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1282.51s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (610.46s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (1998.87s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1068.63s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1118.99s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1139.68s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (2.76s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1119.07s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1098.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (1189.44s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1401.22s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1219.37s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1360.74s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1295.69s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1118.61s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1712.39s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1522.18s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1128.54s)
--- FAIL: TestAccAWSDBInstance_MSSQL_TZ (6.17s)
--- FAIL: TestAccAWSDBInstance_MSSQL_Domain (34.99s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (1997.37s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (587.99s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1229.02s)
--- FAIL: TestAccAWSDBInstance_ec2Classic (0.39s)
--- FAIL: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (4.73s)
--- FAIL: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (5.10s)
--- FAIL: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (2.44s)
--- PASS: TestAccAWSDBInstance_portUpdate (517.83s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (750.91s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (750.27s)
--- FAIL: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (2.39s)
--- FAIL: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (2.54s)
--- FAIL: TestAccAWSRDSDBInstance_PerformanceInsightsKmsKeyId (3.76s)
--- FAIL: TestAccAWSRDSDBInstance_PerformanceInsightsRetentionPeriod (1.95s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (3.19s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (3.38s)
--- PASS: TestAccAWSDBInstance_separate_iops_update (688.90s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1138.72s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1098.92s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1130.37s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1097.93s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1299.97s)
--- PASS: TestAccAWSDBInstance_MinorVersion (461.69s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1250.02s)
--- FAIL: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (659.84s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (483.26s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (553.46s)
--- FAIL: TestAccAWSDBInstance_CACertificateIdentifier (448.21s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (582.95s)
--- FAIL: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (1063.05s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1855.19s)

Commercial (failures are unrelated or flaky):

--- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (25.37s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (435.29s)
--- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (480.98s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (502.09s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (505.88s)
--- PASS: TestAccAWSDBInstance_iamAuth (521.89s)
--- PASS: TestAccAWSDBInstance_namePrefix (522.75s)
--- PASS: TestAccAWSDBInstance_generatedName (542.86s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (543.95s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (581.48s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- PASS: TestAccAWSDBInstance_kmsKey (585.18s)
--- PASS: TestAccAWSDBInstance_optionGroup (601.96s)
--- PASS: TestAccAWSDbInstanceDataSource_basic (608.75s)
--- PASS: TestAccAWSDBInstance_Password (638.74s)
--- PASS: TestAccAWSDBInstance_basic (649.95s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (692.23s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (714.08s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (915.27s)
--- PASS: TestAccAWSDBInstance_subnetGroup (962.76s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (627.52s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1271.69s)
--- FAIL: TestAccAWSDBInstance_S3Import (732.40s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1317.65s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1362.36s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1388.40s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1520.11s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1953.31s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1389.68s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1408.88s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1320.28s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1428.77s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1601.39s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1660.36s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1604.82s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1431.82s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1763.28s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1221.41s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (534.29s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (2227.15s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2135.77s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (2362.92s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1668.22s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1225.72s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (1115.87s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1528.11s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1246.33s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1407.84s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1279.13s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1278.36s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1199.63s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1208.38s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1595.08s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1260.70s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1719.49s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1376.64s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (728.30s)
--- PASS: TestAccAWSDBInstance_portUpdate (587.46s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (816.11s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1286.12s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (774.65s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1232.65s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1037.37s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2359.24s)
--- PASS: TestAccAWSDBInstance_separate_iops_update (799.95s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1457.17s)
--- PASS: TestAccAWSDBInstance_ec2Classic (507.51s)
--- PASS: TestAccAWSDBInstance_MinorVersion (588.72s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1347.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1297.86s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (2004.03s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (552.79s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (509.19s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (549.28s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (691.30s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (600.13s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (507.16s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (808.02s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (792.59s)
--- FAIL: TestAccAWSRDSDBInstance_PerformanceInsightsKmsKeyId (675.34s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (821.65s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsRetentionPeriod (831.70s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1726.05s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1245.57s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1458.55s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (2160.57s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (2995.24s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (4030.45s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3437.84s)

@bflad
Copy link
Member Author

bflad commented Sep 17, 2020

Yeah sorry, this was intentionally only to fix the two consistent _ec2Classic Commercial failures due to the instance types. The overall EC2-Classic handling in the testing still needs to be handled via #8316, unless you'd like me to try to fix that now.

@YakDriver
Copy link
Member

I was just waiting for TC. Looks good!

@bflad bflad added this to the v3.8.0 milestone Sep 17, 2020
@bflad bflad merged commit f9747e1 into master Sep 17, 2020
@bflad bflad deleted the t-rds-ec2-classic-instance-types branch September 17, 2020 23:33
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

tests/service/rds: Remove hardcoded aws_db_instance instance types in EC2-Classic
2 participants
@bflad @YakDriver