Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/service/rds: Remove hardcoded instance classes from EC2-Classic tests and basic data source test #15184

Merged
merged 1 commit into from
Sep 17, 2020

Commits on Sep 16, 2020

  1. tests/service/rds: Remove hardcoded instance classes from EC2-Classic…

    … tests and basic data source test
    
    Reference: #15182
    
    Previously:
    
    ```
    === CONT  TestAccAWSDBInstance_ec2Classic
    TestAccAWSDBInstance_ec2Classic: resource_aws_db_instance_test.go:2248: Step 1/1 error: terraform failed: exit status 1
    stderr:
    Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time.
      status code: 400, request id: 5bc39058-0571-4f63-bb80-c25533285646
    --- FAIL: TestAccAWSDBInstance_ec2Classic (5.31s)
    
    === CONT  TestAccAWSDbInstanceDataSource_ec2Classic
    TestAccAWSDbInstanceDataSource_ec2Classic: data_source_aws_db_instance_test.go:51: Step 1/1 error: terraform failed: exit status 1
    stderr:
    Error: Error creating DB Instance: InsufficientDBInstanceCapacity: Cannot create a db.m5.large database instance because there are no availability zones with sufficient capacity for non-VPC and storage type : gp2 for db.m5.large. Please try the request again at a later time.
      status code: 400, request id: 38414095-00df-4a5d-ba25-241b5c400ef6
    --- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (15.24s)
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSDbInstanceDataSource_basic (617.92s)
    --- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (456.35s)
    
    --- PASS: TestAccAWSDBInstance_ec2Classic (406.18s)
    ```
    bflad committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    b60e2c4 View commit details
    Browse the repository at this point in the history