tests/provider: Fixes for testing provider re-configuration

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #8316
Reference: #15737
Reference: #15791

Release note for CHANGELOG:

NONE

Applies two fixes for provider re-configuration issues:

• The testAccProviderFactories map should always return a new provider instance every invocation, otherwise concurrent testing with differing provider configurations can overwrite each other since the testing framework can reuse the same underlying provider instance address across multiple gRPC plugin configurations.
• The testAccPreCheck() function is invoked for every test and unnecessarily verifies and reconfigures the "main" provider instance every time to the same configuration.

Adds comments around all this functionality to hopefully make this section of the code clearer for future travelers.

Output from acceptance testing (provided as smoke testing with differing provider configurations in the same testing invocation):

--- PASS: TestAccAWSEIPAssociation_instance (94.34s)
--- PASS: TestAccAWSEIPAssociation_ec2Classic (218.07s)

[YakDriver]

Is this expected on GovCloud for now?

    provider_test.go:213: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
        	status code: 403, request id: 987c445a-d887-4e7e-aacd-d98e84e3b7d6  []}]
--- FAIL: TestAccAWSEIPAssociation_ec2Classic (0.21s)
--- PASS: TestAccAWSEIPAssociation_instance (105.15s)

[YakDriver]

Locally, I'm consistently getting errors on commercials (same thing on 3 runs):

    resource_aws_eip_association_test.go:103: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
        -/+ destroy and then create replacement
        
        Terraform will perform the following actions:
        
          # aws_eip_association.test must be replaced
        -/+ resource "aws_eip_association" "test" {
              + allocation_id        = (known after apply)
              ~ id                   = "107.20.142.12" -> (known after apply)
              + instance_id          = "i-04820728183b496a3"
              + network_interface_id = (known after apply)
              + private_ip_address   = (known after apply)
                public_ip            = "107.20.142.12"
            }
        
        Plan: 1 to add, 0 to change, 1 to destroy.
--- FAIL: TestAccAWSEIPAssociation_ec2Classic (81.04s)

[bflad]

I was probably testing with the fixes from #16032 too, really any testing working with this covers the changes since its critical path for every test.

[YakDriver]

@bflad Apologies for the force push, just a rebase. With it, this PR is now passing.

GovCloud:

    ec2_classic_test.go:54: this test can only run in EC2-Classic, platforms available in us-gov-west-1: ["VPC"]
--- SKIP: TestAccAWSEIPAssociation_ec2Classic (2.80s)
--- PASS: TestAccAWSEIPAssociation_instance (85.07s)

Commercial:

--- PASS: TestAccAWSEIPAssociation_ec2Classic (212.95s)
--- PASS: TestAccAWSEIPAssociation_instance (90.99s)

[YakDriver]

Utmärkt arbete! 💯

[ghost]

This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!