Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Fixes for testing provider re-configuration #16018

Merged
merged 1 commit into from
Nov 13, 2020
Merged

tests/provider: Fixes for testing provider re-configuration #16018

merged 1 commit into from
Nov 13, 2020

Commits on Nov 12, 2020

  1. tests/provider: Fixes for testing provider re-configuration 

    Applies two fixes for provider re-configuration issues:

* The `testAccProviderFactories` map should always return a new provider instance every invocation, otherwise concurrent testing with differing provider configurations can overwrite each other since the testing framework can reuse the same underlying  provider instance address across multiple gRPC plugin configurations.
* The `testAccPreCheck()` function is invoked for every test and unnecessarily verifies and reconfigures the "main" provider instance every time to the same configuration.

Adds comments around all this functionality to hopefully make this section of the code clearer for future travelers.
    @bflad @YakDriver
    bflad authored and YakDriver committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    449762a View commit details
    Browse the repository at this point in the history