r/rds_cluster_instance: Add support for performance_insights_retention_period

[bobziuchkovski]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Superceded by #17111
Closes #9307

Output from acceptance testing for the new test covering performance_insights_retention_period:

$ make testacc TESTARGS='-run=TestAccAWSRDSClusterInstance_PerformanceInsightsRetentionPeriod'                               [13:39:50]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSClusterInstance_PerformanceInsightsRetentionPeriod -timeout 180m
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsRetentionPeriod
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsRetentionPeriod
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsRetentionPeriod
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsRetentionPeriod (935.64s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       940.219s

[github-actions]

Welcome @bobziuchkovski 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[bobziuchkovski]

I tried to make sure I followed all of the contribution guidelines/docs and updated everything that needs updating. Please let me know if I've missed anything. I've confirmed on my end that in addition to the added acceptance test passing, this works correctly for our company's RDS cluster config where we wanted to use this feature.

[drewmullen]

i dont know this resource but heres some feedback on the schema after looking at the API:

• you should add a validation function to your new parameter. per the docs:

Valid values are 7 or 731 (2 years).

• should not be computed if you can set a value
• should set a default if this is the APIs behavior

something like:

			"performance_insights_retention_period": {
				Type:     schema.TypeInt,
				Optional: true,
				Default: 7,
				ValidateFunc: validation.IntInSlice([]int{7, 731}),
			},

[YakDriver]

Thank you for your work on this! Your commits were included with #17111. Of course, you still receive credit for them.

[github-actions]

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.