Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_kendra_faq #25523

Merged
merged 9 commits into from
Jun 23, 2022
Merged

d/aws_kendra_faq #25523

merged 9 commits into from
Jun 23, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKendraFaqData' PKG=kendra ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 5  -run=TestAccKendraFaqData -timeout 180m
=== RUN   TestAccKendraFaqDataSource_basic
=== PAUSE TestAccKendraFaqDataSource_basic
=== CONT  TestAccKendraFaqDataSource_basic
--- PASS: TestAccKendraFaqDataSource_basic (993.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     993.851s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 22, 2022
@anGie44 anGie44 mentioned this pull request Jun 22, 2022
Closed
@anGie44 anGie44 added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 22, 2022
@anGie44 anGie44 self-assigned this Jun 23, 2022
anGie44
anGie44 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GlennChia , LGTM 🚀

Output of acceptance test:

--- PASS: TestAccKendraFaqDataSource_basic (998.43s)

website/docs/d/kendra_index.html.markdown
Comment on lines +23 to +29
The following arguments are supported:

* `id` - (Required) Returns information on a specific Index by id.

## Attributes Reference

In addition to all of the attributes above, the following attributes are exported:
In addition to all of the arguments above, the following attributes are exported:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought our doc linters would of caught these 😅 nice catch!

@anGie44 anGie44 added this to the v4.20.0 milestone Jun 23, 2022
@anGie44 anGie44 merged commit a37397d into hashicorp:main Jun 23, 2022
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
@GlennChia GlennChia deleted the f-aws_kendra_faq branch August 6, 2022 02:56
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GlennChia @anGie44 @justinretzolk