Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Plugin SDK helper/id and helper/retry packages #30307

Merged
merged 14 commits into from
Mar 31, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Mar 29, 2023

Description

Replaces deprecated functions and values from the terraform-plugin-sdk helper/resource package to helper/id or helper/retry.

Restores staticcheck check SA1019 for deprecations to catch uses removed in this PR. Currently has a large number of exclusions for deprecations in:

  • Go
  • AWS SDKs
  • terraform-plugin-sdk

Relations

Closes #30163

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Mar 29, 2023
@gdavison gdavison marked this pull request as ready for review March 29, 2023 07:16
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@gdavison gdavison merged commit 0a77465 into main Mar 31, 2023
@gdavison gdavison deleted the td-refactor-sdk-helpers branch March 31, 2023 21:51
@github-actions github-actions bot added this to the v4.62.0 milestone Mar 31, 2023
github-actions bot pushed a commit that referenced this pull request Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Plugin SDK helper/id and helper/retry packages
2 participants