-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional attribute to aws_vpc_endpoint
data source
#32517
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc TESTS=TestAccVPCEndpointDataSource PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointDataSource' -timeout 180m
--- PASS: TestAccVPCEndpointDataSource_byTags (37.27s)
--- PASS: TestAccVPCEndpointDataSource_byID (37.29s)
--- PASS: TestAccVPCEndpointDataSource_byFilter (37.32s)
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (39.01s)
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (40.96s)
--- PASS: TestAccVPCEndpointDataSource_interface (177.08s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 180.440s
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
private_dns_only_for_inbound_resolver_endpoint
attribute todata.aws_vpc_endpoint.dns_options
, and documents thedata.aws_vpc_endpoint.dns_options
block, which was missing from the documentation.Relations
Closes #32508
References
dns_options
is already setflattenDNSOptions
functionOutput from Acceptance Testing