Fix: Setting default values for scale_in_protected_instances and standby_instances as per documentation

[adiospeds]

Description

Since #33310 was merged we are getting below error:

│ Error: starting Auto Scaling Group (terraform-x) instance refresh: ValidationError: 2 validation errors detected: 
Value '' at 'preferences.scaleInProtectedInstances' failed to satisfy constraint: Member must satisfy enum value set: [Ignore, Wait, Refresh]; 
Value '' at 'preferences.standbyInstances' failed to satisfy constraint: Member must satisfy enum value set: [Terminate, Ignore, Wait]

While the documentation for the above parameters says the Default value for the above arguments scale_in_protected_instances and standby_instances is Wait I think we forgot to add it to the code.

Relations

Relates #33310.
Closes #33377.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @adiospeds 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[mhowell-ims]

I wonder if 'Wait' is actually the right option for the default value. Using 'Wait' actually requires manual intervention if it gets triggered, which seems to go against the spirit of infrastructure-as-code. It would also cause the instance refresh to 'pause' for up to an hour while waiting for manual intervention to occur, which could cause other issues. The AWS web console actually recommends 'Ignore' for both of these settings.

[adiospeds]

@mhowell-ims I agree to what you are saying. During troubleshooting this bug, Wait seemed a better option but longer term and as recommended by AWS GUI above, Ignore seems to be even more better option. Thank you for the suggestion and making this fix better. Pushing the change for your suggestion and I'll also have the documentation updated.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_InstanceRefresh_' PKG=autoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingGroup_InstanceRefresh_ -timeout 180m
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_triggers
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_autoRollback (188.24s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_start
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (212.21s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (344.02s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (262.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	456.268s

[ewbankkit]

@adiospeds Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.16.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.