Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Instance refresh preferences #245

Conversation

magreenbaum
Copy link
Member

Description

Add scale_in_protected_instances and standby_instances to aws_autoscaling_group instance_refresh.preferences.
Add ignore_failed_scaling_activities.

Motivation and Context

Min provider version 5.16.2 based on hashicorp/terraform-provider-aws#33382
Additional instance_refresh.preferences: hashicorp/terraform-provider-aws#33310
ignore_failed_scaling_activities: hashicorp/terraform-provider-aws#32914

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@bryantbiggs bryantbiggs merged commit f3ffe36 into terraform-aws-modules:master Oct 11, 2023
7 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 11, 2023
## [7.1.0](v7.0.0...v7.1.0) (2023-10-11)

### Features

* Instance refresh preferences ([#245](#245)) ([f3ffe36](f3ffe36))
@antonbabenko
Copy link
Member

This PR is included in version 7.1.0 🎉

@magreenbaum magreenbaum deleted the feat/instance_refresh_preferences branch October 11, 2023 12:44
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants