Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blue/green deployment block to Aurora (WIP) #33812

Closed
wants to merge 14 commits into from

Conversation

autotune
Copy link
Contributor

@autotune autotune commented Oct 8, 2023

Adds an option for blue/green deployments to RDS MySQL Aurora.

resource "aws_rds_cluster" "default" {

 blue_green_update { 
    enabled =  false 
 }
  cluster_identifier = "aurora-cluster-demo-old"
  availability_zones = ["us-east-1b", "us-east-1c", "us-east-1d"]
  database_name      = "mydb"
  master_username    = "foo"
  master_password    = "barbut8chars"
  engine             = "aurora-mysql"
  skip_final_snapshot = true
  db_cluster_parameter_group_name = "green"
}

resource "aws_rds_cluster_instance" "cluster_instances" {
  depends_on         = [aws_rds_cluster.default]
  count              = 2 
  identifier         = "aurora-cluster-demo-${count.index}"
  cluster_identifier = aws_rds_cluster.default.id
  engine             = aws_rds_cluster.default.engine
  engine_version     = aws_rds_cluster.default.engine_version
  instance_class     = "db.x2g.large"
  db_parameter_group_name = "logicalreplication2"
}

Change to true after resources are created.

Relations

Closes #28956

Output from Acceptance Testing

There is no acceptance testing for the original code. This requires existing resources already in place I'm not sure it's possible to create tests for this.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. labels Oct 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 8, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 12, 2023
@gdavison gdavison self-assigned this Oct 16, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 16, 2023
@autotune
Copy link
Contributor Author

autotune commented Oct 18, 2023

I'm closing this in favor of #33978, which turns this into its own resource that tests can be implemented for.

@autotune autotune closed this Oct 18, 2023
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label Oct 18, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Aurora Blue/Green Update
2 participants