-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RDS Aurora MySQL blue/green deployment resource and test (testing WIP) #33978
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Extra markdown file.
@justinretzolk I have not been able to build a test for this as the parameter group is unable to wait for Aurora DB instance creation. Going to submit what I've finished so far today, if someone else wants to take over and finish building out the test portion that is fine with me. |
|
||
} | ||
return true, err | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal/service/rds/cluster_blue_green_resource.go:979:7: syntax error: unexpected comma at end of statement
) | ||
} | ||
} | ||
}() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal/service/rds/cluster_blue_green_resource.go:983:3: syntax error: unexpected ( after top level declaration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @autotune,
In this section of code, there is some funky bracing and indentation issues preventing us from getting past linting to build. I'm trying to debug this issue, but when I fix the braces and indentation I find references to variables that don't exist. Can you fill us in on what you think is going on in this code block?
Thanks for the work you've put into this, @autotune. Unfortunately, a stand-alone resource for RDS Blue/Green Deployments does not fit with the Terraform model of declarative infrastructure: Using the resource would require multiple iterations of editing the Terraform configuration, applying the configuration, or importing resources. A separate tool that can manage the orchestration steps would be a better fit. Blue/Green Deployments work with For more details, see #34551 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #0000
--->
Closes #28956
Output from Acceptance Testing
WIP