-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set EKS properties on batch #34931
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=batch TESTS=TestAccBatchJobDefinition_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobDefinition_' -timeout 360m
--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (7.92s)
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (8.09s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (21.23s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (21.49s)
--- PASS: TestAccBatchJobDefinition_basic (21.51s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (21.68s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (24.66s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (24.76s)
--- PASS: TestAccBatchJobDefinition_propagateTags (26.51s)
--- PASS: TestAccBatchJobDefinition_disappears (27.29s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (29.56s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (30.50s)
--- PASS: TestAccBatchJobDefinition_updateForcesNewResource (30.51s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (31.89s)
--- PASS: TestAccBatchJobDefinition_NodePropertiesupdateForcesNewResource (32.64s)
--- PASS: TestAccBatchJobDefinition_tags (36.83s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 40.082s
Thanks for your contribution, @danquack! Just replaced a couple inline strings with enum value helpers (missing from the AWS SDK). |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR unlocks a test case for #34663.
Relations
Closes #29383
References
Output from Acceptance Testing