-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Prometheus scraper role ARN #35453
Export Prometheus scraper role ARN #35453
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Forgot the role arn description in the doc. Will push a commit asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAMPScraper_basic' PKG=amp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 20 -run=TestAccAMPScraper_basic -timeout 360m
=== RUN TestAccAMPScraper_basic
=== PAUSE TestAccAMPScraper_basic
=== CONT TestAccAMPScraper_basic
--- PASS: TestAccAMPScraper_basic (2124.06s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amp 2139.762s
@bonclay7 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Prometheus scraper exposes a role ARN specific to the resource, and can be used for multiple purposes including automating scraper authentication in EKS.
Relations
Closes #35322
Output from Acceptance Testing