Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_lb: enable_http2 flag for LBs and small refactor #3609

Merged
merged 2 commits into from
Mar 6, 2018
Merged

resource/aws_lb: enable_http2 flag for LBs and small refactor #3609

merged 2 commits into from
Mar 6, 2018

Commits on Mar 2, 2018

  1. enable_http2 flag for LBs and small refactor 

    - refactored to use a switch statement a la hashicorp#3578
- added enable_http2 as a flag with tests
- made the boolean flag tests have 3 steps: on, off, on. to test creation, removal and enabling of a running LB
- increased timeout and delay for aws_internet_gateway detachment refresh
- increased wait time to wait for network interfaces to be destroyed after deleting an NLB (this, combined with the above, caused the EIP hanging resource I saw yesterday)
- made all test fixtures use lb_test as the name for the aws_lb (to prevent the typo issue I had)
    @mpilar
    mpilar committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    7960f1c View commit details
    Browse the repository at this point in the history

  2. Correct lb type switch statement and add tests 

    === RUN   TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (373.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	373.854s
    @mpilar
    mpilar committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    4c4f988 View commit details
    Browse the repository at this point in the history