Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efs awssdkv2 migration #38017

Merged
merged 29 commits into from
Jul 5, 2024
Merged

Conversation

mattburgess
Copy link
Collaborator

Description

Relations

Closes #36152

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@mattburgess mattburgess requested a review from a team as a code owner June 17, 2024 21:35
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/efs Issues and PRs that pertain to the efs service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jun 17, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jun 17, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jun 21, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 25, 2024
# Conflicts:
#	go.mod
#	go.sum
#	internal/service/efs/service_endpoints_gen_test.go
#	internal/service/efs/service_package_gen.go
@ewbankkit ewbankkit self-assigned this Jul 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 5, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEFS' PKG=efs ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/efs/... -v -count 1 -parallel 3  -run=TestAccEFS -timeout 360m
=== RUN   TestAccEFSAccessPointDataSource_basic
=== PAUSE TestAccEFSAccessPointDataSource_basic
=== RUN   TestAccEFSAccessPoint_basic
=== PAUSE TestAccEFSAccessPoint_basic
=== RUN   TestAccEFSAccessPoint_Root_directory
=== PAUSE TestAccEFSAccessPoint_Root_directory
=== RUN   TestAccEFSAccessPoint_RootDirectoryCreation_info
=== PAUSE TestAccEFSAccessPoint_RootDirectoryCreation_info
=== RUN   TestAccEFSAccessPoint_POSIX_user
=== PAUSE TestAccEFSAccessPoint_POSIX_user
=== RUN   TestAccEFSAccessPoint_POSIXUserSecondary_gids
=== PAUSE TestAccEFSAccessPoint_POSIXUserSecondary_gids
=== RUN   TestAccEFSAccessPoint_tags
=== PAUSE TestAccEFSAccessPoint_tags
=== RUN   TestAccEFSAccessPoint_disappears
=== PAUSE TestAccEFSAccessPoint_disappears
=== RUN   TestAccEFSAccessPointsDataSource_basic
=== PAUSE TestAccEFSAccessPointsDataSource_basic
=== RUN   TestAccEFSAccessPointsDataSource_empty
=== PAUSE TestAccEFSAccessPointsDataSource_empty
=== RUN   TestAccEFSBackupPolicy_basic
=== PAUSE TestAccEFSBackupPolicy_basic
=== RUN   TestAccEFSBackupPolicy_Disappears_fs
=== PAUSE TestAccEFSBackupPolicy_Disappears_fs
=== RUN   TestAccEFSBackupPolicy_update
=== PAUSE TestAccEFSBackupPolicy_update
=== RUN   TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN   TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== RUN   TestAccEFSFileSystemDataSource_name
=== PAUSE TestAccEFSFileSystemDataSource_name
=== RUN   TestAccEFSFileSystemDataSource_availabilityZone
=== PAUSE TestAccEFSFileSystemDataSource_availabilityZone
=== RUN   TestAccEFSFileSystemDataSource_nonExistent_tags
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_tags
=== RUN   TestAccEFSFileSystemPolicy_basic
=== PAUSE TestAccEFSFileSystemPolicy_basic
=== RUN   TestAccEFSFileSystemPolicy_disappears
=== PAUSE TestAccEFSFileSystemPolicy_disappears
=== RUN   TestAccEFSFileSystemPolicy_policyBypass
=== PAUSE TestAccEFSFileSystemPolicy_policyBypass
=== RUN   TestAccEFSFileSystemPolicy_equivalentPolicies
=== PAUSE TestAccEFSFileSystemPolicy_equivalentPolicies
=== RUN   TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
=== PAUSE TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
=== RUN   TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN   TestAccEFSFileSystem_disappears
=== PAUSE TestAccEFSFileSystem_disappears
=== RUN   TestAccEFSFileSystem_performanceMode
=== PAUSE TestAccEFSFileSystem_performanceMode
=== RUN   TestAccEFSFileSystem_protection
=== PAUSE TestAccEFSFileSystem_protection
=== RUN   TestAccEFSFileSystem_availabilityZoneName
=== PAUSE TestAccEFSFileSystem_availabilityZoneName
=== RUN   TestAccEFSFileSystem_tags
=== PAUSE TestAccEFSFileSystem_tags
=== RUN   TestAccEFSFileSystem_kmsKey
=== PAUSE TestAccEFSFileSystem_kmsKey
=== RUN   TestAccEFSFileSystem_kmsWithoutEncryption
=== PAUSE TestAccEFSFileSystem_kmsWithoutEncryption
=== RUN   TestAccEFSFileSystem_provisionedThroughputInMibps
=== PAUSE TestAccEFSFileSystem_provisionedThroughputInMibps
=== RUN   TestAccEFSFileSystem_throughputMode
=== PAUSE TestAccEFSFileSystem_throughputMode
=== RUN   TestAccEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccEFSFileSystem_lifecyclePolicy
=== RUN   TestAccEFSMountTargetDataSource_basic
=== PAUSE TestAccEFSMountTargetDataSource_basic
=== RUN   TestAccEFSMountTargetDataSource_byAccessPointID
=== PAUSE TestAccEFSMountTargetDataSource_byAccessPointID
=== RUN   TestAccEFSMountTargetDataSource_byFileSystemID
=== PAUSE TestAccEFSMountTargetDataSource_byFileSystemID
=== RUN   TestAccEFSMountTarget_basic
=== PAUSE TestAccEFSMountTarget_basic
=== RUN   TestAccEFSMountTarget_disappears
=== PAUSE TestAccEFSMountTarget_disappears
=== RUN   TestAccEFSMountTarget_ipAddress
=== PAUSE TestAccEFSMountTarget_ipAddress
=== RUN   TestAccEFSMountTarget_IPAddress_emptyString
=== PAUSE TestAccEFSMountTarget_IPAddress_emptyString
=== RUN   TestAccEFSReplicationConfiguration_basic
=== PAUSE TestAccEFSReplicationConfiguration_basic
=== RUN   TestAccEFSReplicationConfiguration_disappears
=== PAUSE TestAccEFSReplicationConfiguration_disappears
=== RUN   TestAccEFSReplicationConfiguration_allAttributes
=== PAUSE TestAccEFSReplicationConfiguration_allAttributes
=== RUN   TestAccEFSReplicationConfiguration_existingDestination
=== PAUSE TestAccEFSReplicationConfiguration_existingDestination
=== CONT  TestAccEFSAccessPointDataSource_basic
=== CONT  TestAccEFSFileSystem_basic
=== CONT  TestAccEFSMountTargetDataSource_basic
--- PASS: TestAccEFSFileSystem_basic (20.49s)
=== CONT  TestAccEFSBackupPolicy_update
--- PASS: TestAccEFSAccessPointDataSource_basic (22.49s)
=== CONT  TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
--- PASS: TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc (21.49s)
=== CONT  TestAccEFSFileSystemPolicy_equivalentPolicies
--- PASS: TestAccEFSBackupPolicy_update (41.41s)
=== CONT  TestAccEFSFileSystemPolicy_policyBypass
--- PASS: TestAccEFSFileSystemPolicy_equivalentPolicies (21.74s)
=== CONT  TestAccEFSFileSystemPolicy_disappears
--- PASS: TestAccEFSFileSystemPolicy_disappears (17.97s)
=== CONT  TestAccEFSFileSystemPolicy_basic
--- PASS: TestAccEFSFileSystemPolicy_policyBypass (27.68s)
=== CONT  TestAccEFSFileSystemDataSource_nonExistent_tags
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (18.85s)
=== CONT  TestAccEFSFileSystemDataSource_availabilityZone
--- PASS: TestAccEFSFileSystemPolicy_basic (28.27s)
=== CONT  TestAccEFSFileSystemDataSource_name
--- PASS: TestAccEFSMountTargetDataSource_basic (126.24s)
=== CONT  TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSFileSystemDataSource_availabilityZone (19.27s)
=== CONT  TestAccEFSFileSystemDataSource_id
--- PASS: TestAccEFSFileSystemDataSource_name (18.20s)
=== CONT  TestAccEFSMountTarget_IPAddress_emptyString
--- PASS: TestAccEFSFileSystemDataSource_id (18.13s)
=== CONT  TestAccEFSReplicationConfiguration_existingDestination
--- PASS: TestAccEFSFileSystemDataSource_tags (19.94s)
=== CONT  TestAccEFSReplicationConfiguration_allAttributes
--- PASS: TestAccEFSMountTarget_IPAddress_emptyString (128.13s)
=== CONT  TestAccEFSReplicationConfiguration_disappears
--- PASS: TestAccEFSReplicationConfiguration_allAttributes (534.01s)
=== CONT  TestAccEFSReplicationConfiguration_basic
--- PASS: TestAccEFSReplicationConfiguration_disappears (533.62s)
=== CONT  TestAccEFSFileSystem_kmsKey
--- PASS: TestAccEFSFileSystem_kmsKey (21.42s)
=== CONT  TestAccEFSFileSystem_lifecyclePolicy
--- PASS: TestAccEFSFileSystem_lifecyclePolicy (62.18s)
=== CONT  TestAccEFSFileSystem_throughputMode
--- PASS: TestAccEFSFileSystem_throughputMode (29.53s)
=== CONT  TestAccEFSFileSystem_provisionedThroughputInMibps
--- PASS: TestAccEFSFileSystem_provisionedThroughputInMibps (29.12s)
=== CONT  TestAccEFSFileSystem_kmsWithoutEncryption
--- PASS: TestAccEFSFileSystem_kmsWithoutEncryption (5.69s)
=== CONT  TestAccEFSMountTarget_basic
--- PASS: TestAccEFSMountTarget_basic (212.23s)
=== CONT  TestAccEFSMountTarget_ipAddress
--- PASS: TestAccEFSReplicationConfiguration_basic (535.58s)
=== CONT  TestAccEFSMountTarget_disappears
=== CONT  TestAccEFSAccessPoint_tags
--- PASS: TestAccEFSMountTarget_ipAddress (127.50s)
--- PASS: TestAccEFSAccessPoint_tags (39.84s)
=== CONT  TestAccEFSBackupPolicy_Disappears_fs
--- PASS: TestAccEFSBackupPolicy_Disappears_fs (19.86s)
=== CONT  TestAccEFSBackupPolicy_basic
--- PASS: TestAccEFSMountTarget_disappears (124.99s)
=== CONT  TestAccEFSAccessPointsDataSource_empty
--- PASS: TestAccEFSAccessPointsDataSource_empty (17.98s)
=== CONT  TestAccEFSAccessPointsDataSource_basic
--- PASS: TestAccEFSBackupPolicy_basic (24.17s)
=== CONT  TestAccEFSAccessPoint_disappears
--- PASS: TestAccEFSAccessPointsDataSource_basic (22.01s)
=== CONT  TestAccEFSFileSystem_tags
--- PASS: TestAccEFSAccessPoint_disappears (22.14s)
=== CONT  TestAccEFSFileSystem_availabilityZoneName
--- PASS: TestAccEFSFileSystem_availabilityZoneName (20.89s)
=== CONT  TestAccEFSFileSystem_protection
--- PASS: TestAccEFSFileSystem_tags (51.45s)
=== CONT  TestAccEFSFileSystem_performanceMode
--- PASS: TestAccEFSFileSystem_protection (27.52s)
=== CONT  TestAccEFSFileSystem_disappears
--- PASS: TestAccEFSFileSystem_performanceMode (16.36s)
=== CONT  TestAccEFSMountTargetDataSource_byFileSystemID
--- PASS: TestAccEFSFileSystem_disappears (17.65s)
=== CONT  TestAccEFSAccessPoint_RootDirectoryCreation_info
--- PASS: TestAccEFSAccessPoint_RootDirectoryCreation_info (23.81s)
=== CONT  TestAccEFSMountTargetDataSource_byAccessPointID
--- PASS: TestAccEFSMountTargetDataSource_byFileSystemID (115.40s)
=== CONT  TestAccEFSAccessPoint_POSIXUserSecondary_gids
--- PASS: TestAccEFSReplicationConfiguration_existingDestination (1428.25s)
=== CONT  TestAccEFSAccessPoint_Root_directory
--- PASS: TestAccEFSAccessPoint_POSIXUserSecondary_gids (23.96s)
=== CONT  TestAccEFSAccessPoint_POSIX_user
--- PASS: TestAccEFSMountTargetDataSource_byAccessPointID (114.76s)
=== CONT  TestAccEFSAccessPoint_basic
--- PASS: TestAccEFSAccessPoint_Root_directory (23.84s)
--- PASS: TestAccEFSAccessPoint_POSIX_user (23.82s)
--- PASS: TestAccEFSAccessPoint_basic (23.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	1618.925s

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6b1aa9e into hashicorp:main Jul 5, 2024
63 checks passed
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 5, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/efs Issues and PRs that pertain to the efs service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] EFS (Elastic File System) Service
3 participants