-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efs awssdkv2 migration #38017
Efs awssdkv2 migration #38017
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
d73a452
to
cfbdb4e
Compare
cfbdb4e
to
3c074fb
Compare
# Conflicts: # go.mod # go.sum # internal/service/efs/service_endpoints_gen_test.go # internal/service/efs/service_package_gen.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEFS' PKG=efs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/efs/... -v -count 1 -parallel 3 -run=TestAccEFS -timeout 360m
=== RUN TestAccEFSAccessPointDataSource_basic
=== PAUSE TestAccEFSAccessPointDataSource_basic
=== RUN TestAccEFSAccessPoint_basic
=== PAUSE TestAccEFSAccessPoint_basic
=== RUN TestAccEFSAccessPoint_Root_directory
=== PAUSE TestAccEFSAccessPoint_Root_directory
=== RUN TestAccEFSAccessPoint_RootDirectoryCreation_info
=== PAUSE TestAccEFSAccessPoint_RootDirectoryCreation_info
=== RUN TestAccEFSAccessPoint_POSIX_user
=== PAUSE TestAccEFSAccessPoint_POSIX_user
=== RUN TestAccEFSAccessPoint_POSIXUserSecondary_gids
=== PAUSE TestAccEFSAccessPoint_POSIXUserSecondary_gids
=== RUN TestAccEFSAccessPoint_tags
=== PAUSE TestAccEFSAccessPoint_tags
=== RUN TestAccEFSAccessPoint_disappears
=== PAUSE TestAccEFSAccessPoint_disappears
=== RUN TestAccEFSAccessPointsDataSource_basic
=== PAUSE TestAccEFSAccessPointsDataSource_basic
=== RUN TestAccEFSAccessPointsDataSource_empty
=== PAUSE TestAccEFSAccessPointsDataSource_empty
=== RUN TestAccEFSBackupPolicy_basic
=== PAUSE TestAccEFSBackupPolicy_basic
=== RUN TestAccEFSBackupPolicy_Disappears_fs
=== PAUSE TestAccEFSBackupPolicy_Disappears_fs
=== RUN TestAccEFSBackupPolicy_update
=== PAUSE TestAccEFSBackupPolicy_update
=== RUN TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== RUN TestAccEFSFileSystemDataSource_name
=== PAUSE TestAccEFSFileSystemDataSource_name
=== RUN TestAccEFSFileSystemDataSource_availabilityZone
=== PAUSE TestAccEFSFileSystemDataSource_availabilityZone
=== RUN TestAccEFSFileSystemDataSource_nonExistent_tags
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_tags
=== RUN TestAccEFSFileSystemPolicy_basic
=== PAUSE TestAccEFSFileSystemPolicy_basic
=== RUN TestAccEFSFileSystemPolicy_disappears
=== PAUSE TestAccEFSFileSystemPolicy_disappears
=== RUN TestAccEFSFileSystemPolicy_policyBypass
=== PAUSE TestAccEFSFileSystemPolicy_policyBypass
=== RUN TestAccEFSFileSystemPolicy_equivalentPolicies
=== PAUSE TestAccEFSFileSystemPolicy_equivalentPolicies
=== RUN TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
=== PAUSE TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
=== RUN TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN TestAccEFSFileSystem_disappears
=== PAUSE TestAccEFSFileSystem_disappears
=== RUN TestAccEFSFileSystem_performanceMode
=== PAUSE TestAccEFSFileSystem_performanceMode
=== RUN TestAccEFSFileSystem_protection
=== PAUSE TestAccEFSFileSystem_protection
=== RUN TestAccEFSFileSystem_availabilityZoneName
=== PAUSE TestAccEFSFileSystem_availabilityZoneName
=== RUN TestAccEFSFileSystem_tags
=== PAUSE TestAccEFSFileSystem_tags
=== RUN TestAccEFSFileSystem_kmsKey
=== PAUSE TestAccEFSFileSystem_kmsKey
=== RUN TestAccEFSFileSystem_kmsWithoutEncryption
=== PAUSE TestAccEFSFileSystem_kmsWithoutEncryption
=== RUN TestAccEFSFileSystem_provisionedThroughputInMibps
=== PAUSE TestAccEFSFileSystem_provisionedThroughputInMibps
=== RUN TestAccEFSFileSystem_throughputMode
=== PAUSE TestAccEFSFileSystem_throughputMode
=== RUN TestAccEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccEFSFileSystem_lifecyclePolicy
=== RUN TestAccEFSMountTargetDataSource_basic
=== PAUSE TestAccEFSMountTargetDataSource_basic
=== RUN TestAccEFSMountTargetDataSource_byAccessPointID
=== PAUSE TestAccEFSMountTargetDataSource_byAccessPointID
=== RUN TestAccEFSMountTargetDataSource_byFileSystemID
=== PAUSE TestAccEFSMountTargetDataSource_byFileSystemID
=== RUN TestAccEFSMountTarget_basic
=== PAUSE TestAccEFSMountTarget_basic
=== RUN TestAccEFSMountTarget_disappears
=== PAUSE TestAccEFSMountTarget_disappears
=== RUN TestAccEFSMountTarget_ipAddress
=== PAUSE TestAccEFSMountTarget_ipAddress
=== RUN TestAccEFSMountTarget_IPAddress_emptyString
=== PAUSE TestAccEFSMountTarget_IPAddress_emptyString
=== RUN TestAccEFSReplicationConfiguration_basic
=== PAUSE TestAccEFSReplicationConfiguration_basic
=== RUN TestAccEFSReplicationConfiguration_disappears
=== PAUSE TestAccEFSReplicationConfiguration_disappears
=== RUN TestAccEFSReplicationConfiguration_allAttributes
=== PAUSE TestAccEFSReplicationConfiguration_allAttributes
=== RUN TestAccEFSReplicationConfiguration_existingDestination
=== PAUSE TestAccEFSReplicationConfiguration_existingDestination
=== CONT TestAccEFSAccessPointDataSource_basic
=== CONT TestAccEFSFileSystem_basic
=== CONT TestAccEFSMountTargetDataSource_basic
--- PASS: TestAccEFSFileSystem_basic (20.49s)
=== CONT TestAccEFSBackupPolicy_update
--- PASS: TestAccEFSAccessPointDataSource_basic (22.49s)
=== CONT TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
--- PASS: TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc (21.49s)
=== CONT TestAccEFSFileSystemPolicy_equivalentPolicies
--- PASS: TestAccEFSBackupPolicy_update (41.41s)
=== CONT TestAccEFSFileSystemPolicy_policyBypass
--- PASS: TestAccEFSFileSystemPolicy_equivalentPolicies (21.74s)
=== CONT TestAccEFSFileSystemPolicy_disappears
--- PASS: TestAccEFSFileSystemPolicy_disappears (17.97s)
=== CONT TestAccEFSFileSystemPolicy_basic
--- PASS: TestAccEFSFileSystemPolicy_policyBypass (27.68s)
=== CONT TestAccEFSFileSystemDataSource_nonExistent_tags
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (18.85s)
=== CONT TestAccEFSFileSystemDataSource_availabilityZone
--- PASS: TestAccEFSFileSystemPolicy_basic (28.27s)
=== CONT TestAccEFSFileSystemDataSource_name
--- PASS: TestAccEFSMountTargetDataSource_basic (126.24s)
=== CONT TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSFileSystemDataSource_availabilityZone (19.27s)
=== CONT TestAccEFSFileSystemDataSource_id
--- PASS: TestAccEFSFileSystemDataSource_name (18.20s)
=== CONT TestAccEFSMountTarget_IPAddress_emptyString
--- PASS: TestAccEFSFileSystemDataSource_id (18.13s)
=== CONT TestAccEFSReplicationConfiguration_existingDestination
--- PASS: TestAccEFSFileSystemDataSource_tags (19.94s)
=== CONT TestAccEFSReplicationConfiguration_allAttributes
--- PASS: TestAccEFSMountTarget_IPAddress_emptyString (128.13s)
=== CONT TestAccEFSReplicationConfiguration_disappears
--- PASS: TestAccEFSReplicationConfiguration_allAttributes (534.01s)
=== CONT TestAccEFSReplicationConfiguration_basic
--- PASS: TestAccEFSReplicationConfiguration_disappears (533.62s)
=== CONT TestAccEFSFileSystem_kmsKey
--- PASS: TestAccEFSFileSystem_kmsKey (21.42s)
=== CONT TestAccEFSFileSystem_lifecyclePolicy
--- PASS: TestAccEFSFileSystem_lifecyclePolicy (62.18s)
=== CONT TestAccEFSFileSystem_throughputMode
--- PASS: TestAccEFSFileSystem_throughputMode (29.53s)
=== CONT TestAccEFSFileSystem_provisionedThroughputInMibps
--- PASS: TestAccEFSFileSystem_provisionedThroughputInMibps (29.12s)
=== CONT TestAccEFSFileSystem_kmsWithoutEncryption
--- PASS: TestAccEFSFileSystem_kmsWithoutEncryption (5.69s)
=== CONT TestAccEFSMountTarget_basic
--- PASS: TestAccEFSMountTarget_basic (212.23s)
=== CONT TestAccEFSMountTarget_ipAddress
--- PASS: TestAccEFSReplicationConfiguration_basic (535.58s)
=== CONT TestAccEFSMountTarget_disappears
=== CONT TestAccEFSAccessPoint_tags
--- PASS: TestAccEFSMountTarget_ipAddress (127.50s)
--- PASS: TestAccEFSAccessPoint_tags (39.84s)
=== CONT TestAccEFSBackupPolicy_Disappears_fs
--- PASS: TestAccEFSBackupPolicy_Disappears_fs (19.86s)
=== CONT TestAccEFSBackupPolicy_basic
--- PASS: TestAccEFSMountTarget_disappears (124.99s)
=== CONT TestAccEFSAccessPointsDataSource_empty
--- PASS: TestAccEFSAccessPointsDataSource_empty (17.98s)
=== CONT TestAccEFSAccessPointsDataSource_basic
--- PASS: TestAccEFSBackupPolicy_basic (24.17s)
=== CONT TestAccEFSAccessPoint_disappears
--- PASS: TestAccEFSAccessPointsDataSource_basic (22.01s)
=== CONT TestAccEFSFileSystem_tags
--- PASS: TestAccEFSAccessPoint_disappears (22.14s)
=== CONT TestAccEFSFileSystem_availabilityZoneName
--- PASS: TestAccEFSFileSystem_availabilityZoneName (20.89s)
=== CONT TestAccEFSFileSystem_protection
--- PASS: TestAccEFSFileSystem_tags (51.45s)
=== CONT TestAccEFSFileSystem_performanceMode
--- PASS: TestAccEFSFileSystem_protection (27.52s)
=== CONT TestAccEFSFileSystem_disappears
--- PASS: TestAccEFSFileSystem_performanceMode (16.36s)
=== CONT TestAccEFSMountTargetDataSource_byFileSystemID
--- PASS: TestAccEFSFileSystem_disappears (17.65s)
=== CONT TestAccEFSAccessPoint_RootDirectoryCreation_info
--- PASS: TestAccEFSAccessPoint_RootDirectoryCreation_info (23.81s)
=== CONT TestAccEFSMountTargetDataSource_byAccessPointID
--- PASS: TestAccEFSMountTargetDataSource_byFileSystemID (115.40s)
=== CONT TestAccEFSAccessPoint_POSIXUserSecondary_gids
--- PASS: TestAccEFSReplicationConfiguration_existingDestination (1428.25s)
=== CONT TestAccEFSAccessPoint_Root_directory
--- PASS: TestAccEFSAccessPoint_POSIXUserSecondary_gids (23.96s)
=== CONT TestAccEFSAccessPoint_POSIX_user
--- PASS: TestAccEFSMountTargetDataSource_byAccessPointID (114.76s)
=== CONT TestAccEFSAccessPoint_basic
--- PASS: TestAccEFSAccessPoint_Root_directory (23.84s)
--- PASS: TestAccEFSAccessPoint_POSIX_user (23.82s)
--- PASS: TestAccEFSAccessPoint_basic (23.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/efs 1618.925s
@mattburgess Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36152
References
Output from Acceptance Testing