-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5160 arn as an attribute for aws_secretsmanager_secret_version #5488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
5 tests passed (all tests)
=== RUN TestAccAwsSecretsManagerSecretVersion_Basic
--- PASS: TestAccAwsSecretsManagerSecretVersion_Basic (4.31s)
=== RUN TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage (4.47s)
=== RUN TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID (4.61s)
=== RUN TestAccDataSourceAwsSecretsManagerSecretVersion_Basic
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_Basic (5.13s)
=== RUN TestAccAwsSecretsManagerSecretVersion_VersionStages
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (9.12s)
@@ -14,6 +14,10 @@ func dataSourceAwsSecretsManagerSecretVersion() *schema.Resource { | |||
Read: dataSourceAwsSecretsManagerSecretVersionRead, | |||
|
|||
Schema: map[string]*schema.Schema{ | |||
"arn": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the &schema.Schema
here is extraneous since Go 1.7 as its previously defined by the map[string]*schema.Schema
above
@@ -21,6 +21,10 @@ func resourceAwsSecretsManagerSecretVersion() *schema.Resource { | |||
}, | |||
|
|||
Schema: map[string]*schema.Schema{ | |||
"arn": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the &schema.Schema
here is extraneous since Go 1.7 as its previously defined by the map[string]*schema.Schema
above
This has been released in version 1.32.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #5160
Changes proposed in this pull request:
added arn for resource aws_secretsmanager_secret_version
added arn for datasource aws_secretsmanager_secret_version