Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5160 arn as an attribute for aws_secretsmanager_secret_version #5488

Merged
merged 4 commits into from
Aug 9, 2018

Conversation

saravanan30erd
Copy link
Contributor

Fixes #5160

Changes proposed in this pull request:

  • Change 1
    added arn for resource aws_secretsmanager_secret_version
  • Change 2
    added arn for datasource aws_secretsmanager_secret_version

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Aug 9, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. labels Aug 9, 2018
@bflad bflad added this to the v1.32.0 milestone Aug 9, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

5 tests passed (all tests)
=== RUN   TestAccAwsSecretsManagerSecretVersion_Basic
--- PASS: TestAccAwsSecretsManagerSecretVersion_Basic (4.31s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage (4.47s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID (4.61s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_Basic
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_Basic (5.13s)
=== RUN   TestAccAwsSecretsManagerSecretVersion_VersionStages
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (9.12s)

@@ -14,6 +14,10 @@ func dataSourceAwsSecretsManagerSecretVersion() *schema.Resource {
Read: dataSourceAwsSecretsManagerSecretVersionRead,

Schema: map[string]*schema.Schema{
"arn": &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the &schema.Schema here is extraneous since Go 1.7 as its previously defined by the map[string]*schema.Schema above

@@ -21,6 +21,10 @@ func resourceAwsSecretsManagerSecretVersion() *schema.Resource {
},

Schema: map[string]*schema.Schema{
"arn": &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the &schema.Schema here is extraneous since Go 1.7 as its previously defined by the map[string]*schema.Schema above

@bflad bflad merged commit f972c08 into hashicorp:master Aug 9, 2018
bflad added a commit that referenced this pull request Aug 9, 2018
@bflad
Copy link
Contributor

bflad commented Aug 16, 2018

This has been released in version 1.32.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose arn as an attribute for data.aws_secretsmanager_secret_version
2 participants