Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ipv6 properties even if no ipv6 is enabled in subnet #6553

Merged
merged 1 commit into from
Nov 25, 2018

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Nov 22, 2018

This allows usage in conditionals.

Fixes #688 but for subnet instead of VPC

Changes proposed in this pull request:

  • Set ipv6 properties even if no ipv6 is enabled in subnet

Output from acceptance testing:

# make testacc TESTARGS='-run=TestAccAWSSubnet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSubnet_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSubnet_basic
=== PAUSE TestAccAWSSubnet_basic
=== CONT  TestAccAWSSubnet_basic
--- PASS: TestAccAWSSubnet_basic (53.21s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       53.231s

…age in conditionals (fixes terraform-providers#688 but for subnet instead of VPC)
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 22, 2018
@bflad bflad added this to the v1.47.0 milestone Nov 25, 2018
@bflad bflad added the bug Addresses a defect in current functionality. label Nov 25, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix, @pdecat! 🚀

--- PASS: TestAccAWSSubnet_basic (7.53s)
--- PASS: TestAccAWSSubnet_importBasic (10.29s)
--- PASS: TestAccAWSSubnet_enableIpv6 (13.95s)
--- PASS: TestAccAWSSubnet_ipv6 (19.63s)

@bflad bflad merged commit bd6a6f9 into hashicorp:master Nov 25, 2018
@bflad
Copy link
Contributor

bflad commented Nov 30, 2018

This was released (4 days ago) in version 1.47.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@pdecat pdecat deleted the fix-subnet-ipv6-block branch January 16, 2019 10:47
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot conditionally define subnet ipv6 cidr blocks when conditionally defining ipv6 cidr block for vpc
4 participants