Commits on Mar 4, 2019

1. resource/aws_cloudfront_distribution: Allow final creation and update… …

   … timeout retry for AWS Go SDK retries
   
   Reference:
   * #6197
   
   When using `resource.Retry()` for handling eventual consistency, it will timebox the inner function to the configured timeout, which we generally set to a minute or two. The AWS Go SDK, when it encounters recoverable conditions such as 5XX errors or throttling errors, will automatically retry within itself up to the configured session `MaxRetries` (Terraform AWS Provider `max_retries` configuration) before returning to the calling code. For heavily utilized AWS accounts, the throttling errors will cause the outer timeout, which does not give the resource the opportunity to keep retrying outside the timebox.
   
   Here we implement this final retry by checking for timeout error from `resource.Retry()` outside the timeboxing, so the AWS Go SDK can return the proper error messaging in these situations or (hopefully) finally succeed in the case of throttling. Since this error handling condition would require extraneous amounts of resources to only potentially trigger the handling, we do not generally implement covering acceptance testing for this code, but it may be a good candidate for special Terraform AWS Provider handling within a future planned Terraform Provider linting tool.
   
   Output from acceptance testing:
   
   ```
   --- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (2.08s)
   --- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (2.08s)
   --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (1821.71s)
   --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (1821.72s)
   --- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (2086.99s)
   --- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (2090.63s)
   --- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (2092.43s)
   --- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (2092.72s)
   --- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (2097.43s)
   --- PASS: TestAccAWSCloudFrontDistribution_S3Origin (2277.83s)
   --- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (2280.49s)
   --- PASS: TestAccAWSCloudFrontDistribution_customOrigin (2282.05s)
   --- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (3345.90s)
   ```

   

   bflad committed Mar 4, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 26abd93
   • Browse repository at this point

   Copy the full SHA

   26abd93 View commit details

   Browse the repository at this point in the history