Make the ASG delete timeout configurable #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jringuette here's the other part of that ASG PR you opened 😄 |
radeksimko
reviewed
Jun 23, 2017
| @@ -834,7 +838,7 @@ func resourceAwsAutoscalingGroupDrain(d *schema.ResourceData, meta interface{}) | |||
|
|
|||
| // Next, wait for the autoscale group to drain | |||
| log.Printf("[DEBUG] Waiting for group to have zero instances") | |||
| return resource.Retry(10*time.Minute, func() *resource.RetryError { | |||
| return resource.Retry(d.Timeout(schema.TimeoutDelete), func() *resource.RetryError { | |||
There was a problem hiding this comment.
Is there any reason to decrease the default timeout from 10 to 5 mins here?
We could either introduce custom draining timeout or set the default to 10mins, I think.
There was a problem hiding this comment.
Ah no, that's a strange typo or copy/paste error, I'll bump that back up to 10, thanks!
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally hashicorp/terraform#14396
Note that this won't actually respect the delete timeout until hashicorp/terraform#15374 is merged and we bump our internal dependency on
helper/schemaTODO:
Tests passed: