Make the ASG delete timeout configurable

[jringuette]

Fix issue #14394

I've added a configurable delete timeout for the ASG.

I've modified helper/schema/resource.go to read the meta from the state when it is not present in the diff. I'm not sure why this is happening, but on every tries I made, the diff never had the meta info into. It might not be the proper way to fix that problem tough, if someone more familiar with the code base could have a look. But it does not seem to cause any regression nor problem.

Documentation is also updated to reflect the new supported timeout.

[iceycake]

@catsby can you take a look to see if this PR is good? Thanks.

[catsby]

Hey @jringuette can you describe when this was happening?

I've modified helper/schema/resource.go to read the meta from the state when it is not present in the diff.

Was that all the time? Or just certain situation(s)?

[jringuette]

@catsby, It was all the time. It was always returning the default timeout (20 minutes) from here

terraform/helper/schema/resource_data.go

Line 368 in 2fe5976

return 20 * time.Minute

When opening the state file, I was able to see the timeouts correctly saved under the meta e2bfb730-ecaa-11e6-8f88-34363bc7c4c0, but when reading, it always read from the diff which did not contained that meta.

[ledor473]

Any update on this ticket? We faced the same issue recently.

[catsby]

This has been migrated to #15374 and hashicorp/terraform-provider-aws#949

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.