Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application_password object_id argument vs documentation #106

Closed
mjiderhamn opened this issue Jun 10, 2019 · 2 comments · Fixed by #107
Closed

azuread_application_password object_id argument vs documentation #106

mjiderhamn opened this issue Jun 10, 2019 · 2 comments · Fixed by #107

Comments

@mjiderhamn
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The documentation for resource azuread_application_password makes reference to object_id. The provider itself however uses application_id.

The actual value should be the object_id of the azuread_application rather than the application_id, so it is probably more correct to update the code than the documentation.

New or Affected Resource(s)

  • azuread_application_password
@mjiderhamn mjiderhamn changed the title Document object_id azuread_application_password object_id argument vs documentation Jun 10, 2019
@katbyte
Copy link
Collaborator

katbyte commented Jun 10, 2019

Thanks for brining this to light @mjiderhamn, that is a very good point.

I have opened #107 to change the name of that property to application__object_id to make it explicit what is being asked for given that applications have an application_id property.

@ghost
Copy link

ghost commented Jul 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants