application: support for setting oauth2_permissions

[manicminer]

Enable setting OAuth 2.0 permission scopes for an AAD application.

If omitted, will be computed from scopes defined out of band.
If specified, will replace any existing scopes configured for an application.
If specified as empty value, will remove any existing scopes from an application.

Thanks to @jorgecarleitao for initial work on #187

Fixes: #73, #162
Replaces: #187

[katbyte]

@manicminer - would it make sense to include a flag oauth2_permissions_include_default that injects the default permissions? that way you can add your own and not worry about specifying them, as well as clear & reset to the default

[manicminer]

Hi @katbyte, thinking this over a few ways I'm not sure that would work. I can see two options:

1. Hardcode the default scope in the provider and add it on behalf of the user, which feels like it will break at some point?
2. Assume a default scope(s) will be created, which it seems to be, but I've had cases where it was not though I'm not sure exactly what configuration causes this. Also, then we'd have to save the state of any default scopes because they are only added at create time?

Just adding my 2c, as an administrator my personal preference is to be explicit about my application scopes.

[manicminer]

Tests pass

[frank-mueller-ps]

Is there an expected date for the 0.10.0? Because I need exactly this feature for my current project :)

@manicminer
are you able to answer my question?

[manicminer]

Hi @imbatman4711, we're planning on releasing this week which will include this change.

[ghost]

This has been released in version 0.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.10.0"
}
# ... other configuration ...

[nephinj]

Can you provide a sample or better documentation of an empty value? I tried setting oauth2_permissions = [] but it does not seem to work for me and I see values in the manifest.

resource "azuread_application" "Chatbot-adapp" {
name = "${var.prefix}-wapp"
oauth2_permissions = []
oauth2_allow_implicit_flow = false
reply_urls = null
}

[manicminer]

Hi @nephinj, I'm observing some extreme delays at the moment with changes reflecting in the portal for applications. I've just ran a few tests myself - setting and then deleting oauth2_permissions - and the correct updates are being made (and accepted by the API), but it's been over 10 minutes with updates not yet reflecting.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!