Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: resolve several potential crashes in new PIM resources #1375

Merged
merged 2 commits into from
May 13, 2024

Conversation

manicminer
Copy link
Member

Fixes: #1372

@manicminer
Copy link
Member Author

Test results:

Screenshot 2024-05-10 at 22 39 25

Screenshot 2024-05-10 at 22 39 31

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🦺

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manicminer manicminer merged commit 6d64165 into main May 13, 2024
26 checks passed
@manicminer manicminer deleted the bug/pim-crashes branch May 13, 2024 07:19
manicminer added a commit that referenced this pull request May 13, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request May 13, 2024
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azuread&#34; updated from
&#34;2.49.0&#34; to &#34;2.49.1&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.49.1</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.49.1&#xA;BUG
FIXES:&#xA;&#xA;* `data.azuread_group_role_management_policy` - resolve
a potential crash
([#1375](https://github.com/hashicorp/terraform-provider-azuread/issues/1375))&#xA;*
`azuread_group_role_management_policy` - resolve a number of potential
crashes
([#1375](https://github.com/hashicorp/terraform-provider-azuread/issues/1375))&#xA;*
`azuread_privileged_access_group_assignment_schedule` - resolve a number
of potential crashes
([#1375](https://github.com/hashicorp/terraform-provider-azuread/issues/1375))&#xA;*
`azuread_privileged_access_group_eligibility_schedule` - resolve a
number of potential crashes
([#1375](https://github.com/hashicorp/terraform-provider-azuread/issues/1375))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/175/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
BrendanThompson pushed a commit to BrendanThompson/terraform-provider-azuread that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin crash on azuread_privileged_access_group_eligibility_schedule resource with permanent_assignment=true
3 participants