azuread_conditional_access_policy: improve handling of the session_controls block
#1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrols` block - Make `sign_in_frequency_authentication_type` and `sign_in_frequency_internal` both Optional + Computed and remove their default values. - Handle the setting of these default values in the `expandConditionalAccessSessionControls()` function. - Expand test coverage to all reasonable permutatons of the properties in this block to ensure no trailing diff or incorrect setting of values in the request.
manicminer
force-pushed
the
bugfix/conditional-access-session-controls
branch
from
dc82167
to
4f874d3
Compare
|
Test results (failure unrelated) 
|
manicminer
added a commit
that referenced
this pull request
May 16, 2024
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
May 20, 2024
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
<h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azuread" updated from
"2.49.1" to "2.50.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>2.50.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.50.0
ENHANCEMENTS:

*
dependencies: updating to `v0.68.0` of `github.com/manicminer/hamilton`
([#1382](https://github.com/hashicorp/terraform-provider-azuread/issues/1382))
*
`data.azuread_application` - support looking up applications with the
`identifier_uri` property [GH 1303]
*
`azuread_conditional_access_policy` - improve handling of the
`session_controls` block
([#1382](https://github.com/hashicorp/terraform-provider-azuread/issues/1382))

BUG
FIXES:

* `data.azuread_service_principal` - treat the
`display_name` property case-insensitively
([#1381](https://github.com/hashicorp/terraform-provider-azuread/issues/1381))
*
`azuread_conditional_access_policy` - fix a bug that could cause a
persistent diff when setting certain properties in the
`session_controls` block
([#1382](https://github.com/hashicorp/terraform-provider-azuread/issues/1382))
*
`azuread_user` - don't overwrite the existing password in state,
when a password change fails
([#1308](https://github.com/hashicorp/terraform-provider-azuread/issues/1308))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/188/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
BrendanThompson
pushed a commit
to BrendanThompson/terraform-provider-azuread
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on manicminer/hamilton#282
sign_in_frequency_authentication_typeandsign_in_frequency_internalboth Optional + Computed and remove their default values.expandConditionalAccessSessionControls()function.Closes: #1235
Closes: #1347
CHANGELOG
ENHANCEMENTS
v0.68.0ofgithub.com/manicminer/hamiltonazuread_conditional_access_policy- improve handling of thesession_controlsblockBUG FIXES
azuread_conditional_access_policy- fix a bug that could cause a persistent diff when setting certain properties in thesession_controlsblock