Prepare for v1.0 release #298

manicminer · 2020-08-08T02:36:15Z

Summary

Refactor into service packages
Drop the azuread/ top-level directory
Tidy up Application related functions
Use acceptance package for all tests
Bump Go to 1.15
Readme refresh
Updated example configurations
TeamCity build chain as code

CHANGELOG

Provider: requires Terraform 0.12.0 or later
~~Provider: Drop support for configuring a subscription ID, bump SDK version~~ <-- this is blocked and will make it into a minor release
New resource: azuread_application_app_role (closes azuread_application: app_role id can't be specified manually #150, closes Provide support for approle outside of resource_application as an independent resource #306)
New resource: azuread_application_oauth2_permission (closes azuread_application: oauth2_permissions id can't be specified manually #267)
azuread_application - a default value for the homepage attribute is no longer derived when unspecified (closes azuread_application: homepage can't be blank #268)
azuread_application_password - application_id attribute has been dropped
data.azuread_groups and data.azuread_users (both plural data sources) will not error if no results found (see Allow for graceful handling of errored users within users data source #256)
data.azuread_group - name argument is now case insensitive (closes data.azuread_group: name should be case insensitive #246, closes data.azuread_group: name argument is now case insensitive #291)

- Refactor into service packages - Drop support for configuring a subscription ID, bump SDK version - Drop `application_id` attribute on `azuread_application_password` resource - Tidy up Application related functions - Use acceptance module for all tests - Bump Go to 1.15

…m-provider-azuread into release/1.0

- Move provider code into top directory (drop the `azuread/` directory) - Revert to go-azure-helpers v0.12.0 and don't fully remove subscription_id just yet - Rename `METADATA_URL` env var to `METADATA_HOST` - Consolidate helper funcs into a utils package - Remove RP registration config value - Add .tfproto5 to force TF v0.12.x - Remove unnecessary custom timeout - Use a more idempotent ID for `azuread_client_config` data source - `azuread_users` data source to error if no users found - Minor function signature tidying

…ssues where DELETE requests are sometimes not honoured)

…ions, and application/service principal passwords and certificates

manicminer · 2020-08-28T16:10:53Z

Tests passing:

17:00:08 [:~/go/src/github.com/terraform-providers/terraform-provider-azuread]↥ release/1.0 ± make testacc TEST=./internal/services/aadgraph TESTARGS='-run TestAcc -count 1'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/services/aadgraph -v -run TestAcc -count 1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azuread/version.ProviderVersion=acc"
=== RUN   TestAccApplicationAppRole_basic
=== PAUSE TestAccApplicationAppRole_basic
=== RUN   TestAccApplicationAppRole_complete
=== PAUSE TestAccApplicationAppRole_complete
=== RUN   TestAccApplicationAppRole_update
=== PAUSE TestAccApplicationAppRole_update
=== RUN   TestAccApplicationAppRole_requiresImport
=== PAUSE TestAccApplicationAppRole_requiresImport
=== RUN   TestAccApplicationCertificate_basic
=== PAUSE TestAccApplicationCertificate_basic
=== RUN   TestAccApplicationCertificate_complete
=== PAUSE TestAccApplicationCertificate_complete
=== RUN   TestAccApplicationCertificate_relativeEndDate
=== PAUSE TestAccApplicationCertificate_relativeEndDate
=== RUN   TestAccApplicationCertificate_requiresImport
=== PAUSE TestAccApplicationCertificate_requiresImport
=== RUN   TestAccApplicationDataSource_byObjectId
=== PAUSE TestAccApplicationDataSource_byObjectId
=== RUN   TestAccApplicationDataSource_byObjectIdComplete
=== PAUSE TestAccApplicationDataSource_byObjectIdComplete
=== RUN   TestAccApplicationDataSource_byApplicationId
=== PAUSE TestAccApplicationDataSource_byApplicationId
=== RUN   TestAccApplicationDataSource_byName
=== PAUSE TestAccApplicationDataSource_byName
=== RUN   TestAccApplicationOAuth2Permission_basic
=== PAUSE TestAccApplicationOAuth2Permission_basic
=== RUN   TestAccApplicationOAuth2Permission_complete
=== PAUSE TestAccApplicationOAuth2Permission_complete
=== RUN   TestAccApplicationOAuth2Permission_update
=== PAUSE TestAccApplicationOAuth2Permission_update
=== RUN   TestAccApplicationOAuth2Permission_requiresImport
=== PAUSE TestAccApplicationOAuth2Permission_requiresImport
=== RUN   TestAccApplicationPassword_basic
=== PAUSE TestAccApplicationPassword_basic
=== RUN   TestAccApplicationPassword_complete
=== PAUSE TestAccApplicationPassword_complete
=== RUN   TestAccApplicationPassword_relativeEndDate
=== PAUSE TestAccApplicationPassword_relativeEndDate
=== RUN   TestAccApplicationPassword_requiresImport
=== PAUSE TestAccApplicationPassword_requiresImport
=== RUN   TestAccApplication_basic
=== PAUSE TestAccApplication_basic
=== RUN   TestAccApplication_complete
=== PAUSE TestAccApplication_complete
=== RUN   TestAccApplication_update
=== PAUSE TestAccApplication_update
=== RUN   TestAccApplication_http_homepage
=== PAUSE TestAccApplication_http_homepage
=== RUN   TestAccApplication_publicClient
=== PAUSE TestAccApplication_publicClient
=== RUN   TestAccApplication_availableToOtherTenants
=== PAUSE TestAccApplication_availableToOtherTenants
=== RUN   TestAccApplication_appRoles
=== PAUSE TestAccApplication_appRoles
=== RUN   TestAccApplication_appRolesNoValue
=== PAUSE TestAccApplication_appRolesNoValue
=== RUN   TestAccApplication_appRolesUpdate
=== PAUSE TestAccApplication_appRolesUpdate
=== RUN   TestAccApplication_appRolesDelete
=== PAUSE TestAccApplication_appRolesDelete
=== RUN   TestAccApplication_groupMembershipClaimsUpdate
=== PAUSE TestAccApplication_groupMembershipClaimsUpdate
=== RUN   TestAccApplication_native
=== PAUSE TestAccApplication_native
=== RUN   TestAccApplication_nativeReplyUrls
=== PAUSE TestAccApplication_nativeReplyUrls
=== RUN   TestAccApplication_nativeUpdate
=== PAUSE TestAccApplication_nativeUpdate
=== RUN   TestAccApplication_nativeAppDoesNotAllowIdentifierUris
=== PAUSE TestAccApplication_nativeAppDoesNotAllowIdentifierUris
=== RUN   TestAccApplication_oauth2PermissionsUpdate
=== PAUSE TestAccApplication_oauth2PermissionsUpdate
=== RUN   TestAccApplication_preventDuplicateNames
=== PAUSE TestAccApplication_preventDuplicateNames
=== RUN   TestAccApplication_duplicateAppRolesOauth2PermissionsValues
=== PAUSE TestAccApplication_duplicateAppRolesOauth2PermissionsValues
=== RUN   TestAccClientConfigDataSource_basic
=== PAUSE TestAccClientConfigDataSource_basic
=== RUN   TestAccDomainsDataSource_basic
=== PAUSE TestAccDomainsDataSource_basic
=== RUN   TestAccDomainsDataSource_onlyDefault
=== PAUSE TestAccDomainsDataSource_onlyDefault
=== RUN   TestAccDomainsDataSource_onlyInitial
=== PAUSE TestAccDomainsDataSource_onlyInitial
=== RUN   TestAccGroupDataSource_byName
=== PAUSE TestAccGroupDataSource_byName
=== RUN   TestAccGroupDataSource_byCaseInsensitiveName
=== PAUSE TestAccGroupDataSource_byCaseInsensitiveName
=== RUN   TestAccGroupDataSource_byObjectId
=== PAUSE TestAccGroupDataSource_byObjectId
=== RUN   TestAccGroupDataSource_members
=== PAUSE TestAccGroupDataSource_members
=== RUN   TestAccGroupDataSource_owners
=== PAUSE TestAccGroupDataSource_owners
=== RUN   TestAccGroupMember_group
=== PAUSE TestAccGroupMember_group
=== RUN   TestAccGroupMember_servicePrincipal
=== PAUSE TestAccGroupMember_servicePrincipal
=== RUN   TestAccGroupMember_user
=== PAUSE TestAccGroupMember_user
=== RUN   TestAccGroupMember_multipleUser
=== PAUSE TestAccGroupMember_multipleUser
=== RUN   TestAccGroup_basic
=== PAUSE TestAccGroup_basic
=== RUN   TestAccGroup_complete
=== PAUSE TestAccGroup_complete
=== RUN   TestAccGroup_owners
=== PAUSE TestAccGroup_owners
=== RUN   TestAccGroup_members
=== PAUSE TestAccGroup_members
=== RUN   TestAccGroup_membersAndOwners
=== PAUSE TestAccGroup_membersAndOwners
=== RUN   TestAccGroup_membersDiverse
=== PAUSE TestAccGroup_membersDiverse
=== RUN   TestAccGroup_ownersDiverse
=== PAUSE TestAccGroup_ownersDiverse
=== RUN   TestAccGroup_membersUpdate
=== PAUSE TestAccGroup_membersUpdate
=== RUN   TestAccGroup_ownersUpdate
=== PAUSE TestAccGroup_ownersUpdate
=== RUN   TestAccGroup_preventDuplicateNames
=== PAUSE TestAccGroup_preventDuplicateNames
=== RUN   TestAccGroupsDataSource_byUserPrincipalNames
=== PAUSE TestAccGroupsDataSource_byUserPrincipalNames
=== RUN   TestAccGroupsDataSource_byObjectIds
=== PAUSE TestAccGroupsDataSource_byObjectIds
=== RUN   TestAccGroupsDataSource_noNames
=== PAUSE TestAccGroupsDataSource_noNames
=== RUN   TestAccServicePrincipalCertificate_basic
=== PAUSE TestAccServicePrincipalCertificate_basic
=== RUN   TestAccServicePrincipalCertificate_complete
=== PAUSE TestAccServicePrincipalCertificate_complete
=== RUN   TestAccServicePrincipalCertificate_relativeEndDate
=== PAUSE TestAccServicePrincipalCertificate_relativeEndDate
=== RUN   TestAccServicePrincipalCertificate_requiresImport
=== PAUSE TestAccServicePrincipalCertificate_requiresImport
=== RUN   TestAccServicePrincipalDataSource_byApplicationId
=== PAUSE TestAccServicePrincipalDataSource_byApplicationId
=== RUN   TestAccServicePrincipalDataSource_byDisplayName
=== PAUSE TestAccServicePrincipalDataSource_byDisplayName
=== RUN   TestAccServicePrincipalDataSource_byObjectId
=== PAUSE TestAccServicePrincipalDataSource_byObjectId
=== RUN   TestAccServicePrincipalPassword_basic
=== PAUSE TestAccServicePrincipalPassword_basic
=== RUN   TestAccServicePrincipalPassword_complete
=== PAUSE TestAccServicePrincipalPassword_complete
=== RUN   TestAccServicePrincipalPassword_relativeEndDate
=== PAUSE TestAccServicePrincipalPassword_relativeEndDate
=== RUN   TestAccServicePrincipalPassword_requiresImport
=== PAUSE TestAccServicePrincipalPassword_requiresImport
=== RUN   TestAccServicePrincipal_basic
=== PAUSE TestAccServicePrincipal_basic
=== RUN   TestAccServicePrincipal_complete
=== PAUSE TestAccServicePrincipal_complete
=== RUN   TestAccServicePrincipal_update
=== PAUSE TestAccServicePrincipal_update
=== RUN   TestAccUserDataSource_byUserPrincipalName
=== PAUSE TestAccUserDataSource_byUserPrincipalName
=== RUN   TestAccUserDataSource_byUserPrincipalNameNonexistent
=== PAUSE TestAccUserDataSource_byUserPrincipalNameNonexistent
=== RUN   TestAccUserDataSource_byObjectId
=== PAUSE TestAccUserDataSource_byObjectId
=== RUN   TestAccUserDataSource_byObjectIdNonexistent
=== PAUSE TestAccUserDataSource_byObjectIdNonexistent
=== RUN   TestAccUserDataSource_byMailNickname
=== PAUSE TestAccUserDataSource_byMailNickname
=== RUN   TestAccUserDataSource_byMailNicknameNonexistent
=== PAUSE TestAccUserDataSource_byMailNicknameNonexistent
=== RUN   TestAccUser_basic
=== PAUSE TestAccUser_basic
=== RUN   TestAccUser_complete
=== PAUSE TestAccUser_complete
=== RUN   TestAccUser_update
=== PAUSE TestAccUser_update
=== RUN   TestAccUser_threeUsersABC
=== PAUSE TestAccUser_threeUsersABC
=== RUN   TestAccUsersDataSource_byUserPrincipalNames
=== PAUSE TestAccUsersDataSource_byUserPrincipalNames
=== RUN   TestAccUsersDataSource_byUserPrincipalNamesIgnoreMissing
=== PAUSE TestAccUsersDataSource_byUserPrincipalNamesIgnoreMissing
=== RUN   TestAccUsersDataSource_byObjectIds
=== PAUSE TestAccUsersDataSource_byObjectIds
=== RUN   TestAccUsersDataSource_byObjectIdsIgnoreMissing
=== PAUSE TestAccUsersDataSource_byObjectIdsIgnoreMissing
=== RUN   TestAccUsersDataSource_byMailNicknames
=== PAUSE TestAccUsersDataSource_byMailNicknames
=== RUN   TestAccUsersDataSource_byMailNicknamesIgnoreMissing
=== PAUSE TestAccUsersDataSource_byMailNicknamesIgnoreMissing
=== RUN   TestAccUsersDataSource_noNames
=== PAUSE TestAccUsersDataSource_noNames
=== CONT  TestAccApplicationAppRole_basic
=== CONT  TestAccGroupMember_servicePrincipal
=== CONT  TestAccGroupDataSource_byObjectId
=== CONT  TestAccApplicationOAuth2Permission_basic
=== CONT  TestAccGroupMember_group
=== CONT  TestAccGroupDataSource_owners
=== CONT  TestAccGroupDataSource_members
=== CONT  TestAccApplication_http_homepage
=== CONT  TestAccApplication_update
=== CONT  TestAccApplication_complete
=== CONT  TestAccApplication_basic
=== CONT  TestAccApplicationPassword_requiresImport
=== CONT  TestAccApplicationPassword_relativeEndDate
=== CONT  TestAccApplicationPassword_complete
=== CONT  TestAccApplicationPassword_basic
=== CONT  TestAccApplication_publicClient
=== CONT  TestAccApplicationOAuth2Permission_requiresImport
--- PASS: TestAccGroupDataSource_byObjectId (20.68s)
--- PASS: TestAccApplication_http_homepage (22.83s)
=== CONT  TestAccApplicationOAuth2Permission_update
--- PASS: TestAccApplication_basic (23.73s)
=== CONT  TestAccApplicationOAuth2Permission_complete
--- PASS: TestAccApplication_publicClient (23.77s)
=== CONT  TestAccApplication_nativeAppDoesNotAllowIdentifierUris
--- PASS: TestAccApplication_nativeAppDoesNotAllowIdentifierUris (0.02s)
=== CONT  TestAccGroupDataSource_byCaseInsensitiveName
--- PASS: TestAccApplicationOAuth2Permission_basic (25.76s)
=== CONT  TestAccGroupDataSource_byName
--- PASS: TestAccApplicationAppRole_basic (26.71s)
=== CONT  TestAccDomainsDataSource_onlyInitial
--- PASS: TestAccDomainsDataSource_onlyInitial (3.46s)
=== CONT  TestAccDomainsDataSource_onlyDefault
--- PASS: TestAccDomainsDataSource_onlyDefault (2.95s)
=== CONT  TestAccDomainsDataSource_basic
--- PASS: TestAccApplicationPassword_basic (33.20s)
=== CONT  TestAccClientConfigDataSource_basic
--- PASS: TestAccApplicationPassword_relativeEndDate (33.29s)
=== CONT  TestAccApplication_duplicateAppRolesOauth2PermissionsValues
--- PASS: TestAccApplication_duplicateAppRolesOauth2PermissionsValues (0.02s)
=== CONT  TestAccApplication_preventDuplicateNames
--- PASS: TestAccApplication_complete (34.50s)
=== CONT  TestAccApplication_oauth2PermissionsUpdate
--- PASS: TestAccDomainsDataSource_basic (2.66s)
=== CONT  TestAccApplicationCertificate_relativeEndDate
--- PASS: TestAccClientConfigDataSource_basic (2.75s)
=== CONT  TestAccApplicationDataSource_byName
--- PASS: TestAccGroupDataSource_owners (38.53s)
=== CONT  TestAccUsersDataSource_noNames
--- PASS: TestAccApplicationPassword_requiresImport (38.55s)
=== CONT  TestAccUsersDataSource_byMailNicknames
--- PASS: TestAccUsersDataSource_noNames (0.04s)
=== CONT  TestAccApplicationAppRole_requiresImport
--- PASS: TestAccApplicationPassword_complete (39.42s)
=== CONT  TestAccUsersDataSource_byObjectIdsIgnoreMissing
--- PASS: TestAccApplicationOAuth2Permission_requiresImport (21.96s)
=== CONT  TestAccApplicationCertificate_complete
--- PASS: TestAccGroupDataSource_byCaseInsensitiveName (18.85s)
=== CONT  TestAccUsersDataSource_byObjectIds
--- PASS: TestAccApplication_update (45.62s)
=== CONT  TestAccApplicationCertificate_basic
--- PASS: TestAccGroupDataSource_byName (20.61s)
=== CONT  TestAccUsersDataSource_byUserPrincipalNamesIgnoreMissing
--- PASS: TestAccApplicationOAuth2Permission_complete (23.64s)
=== CONT  TestAccUsersDataSource_byUserPrincipalNames
--- PASS: TestAccGroupMember_group (48.95s)
=== CONT  TestAccApplicationDataSource_byObjectId
--- PASS: TestAccApplication_preventDuplicateNames (15.76s)
=== CONT  TestAccUser_threeUsersABC
--- PASS: TestAccApplicationDataSource_byName (19.58s)
=== CONT  TestAccApplicationDataSource_byApplicationId
--- PASS: TestAccUsersDataSource_byMailNicknames (18.86s)
=== CONT  TestAccUser_update
--- PASS: TestAccUsersDataSource_byObjectIdsIgnoreMissing (18.08s)
=== CONT  TestAccUser_complete
--- PASS: TestAccApplicationOAuth2Permission_update (34.68s)
=== CONT  TestAccUsersDataSource_byMailNicknamesIgnoreMissing
--- PASS: TestAccApplicationAppRole_requiresImport (21.19s)
=== CONT  TestAccApplicationCertificate_requiresImport
--- PASS: TestAccGroupMember_servicePrincipal (60.39s)
=== CONT  TestAccApplicationDataSource_byObjectIdComplete
--- PASS: TestAccUsersDataSource_byObjectIds (19.36s)
=== CONT  TestAccServicePrincipalCertificate_relativeEndDate
--- PASS: TestAccUsersDataSource_byUserPrincipalNames (17.95s)
=== CONT  TestAccUserDataSource_byObjectId
--- PASS: TestAccUsersDataSource_byUserPrincipalNamesIgnoreMissing (19.43s)
=== CONT  TestAccUserDataSource_byMailNicknameNonexistent
--- PASS: TestAccApplication_oauth2PermissionsUpdate (32.25s)
=== CONT  TestAccServicePrincipalPassword_requiresImport
--- PASS: TestAccUserDataSource_byMailNicknameNonexistent (1.21s)
=== CONT  TestAccUser_basic
--- PASS: TestAccApplicationCertificate_relativeEndDate (31.23s)
=== CONT  TestAccServicePrincipalPassword_relativeEndDate
--- PASS: TestAccApplicationDataSource_byObjectId (19.59s)
=== CONT  TestAccServicePrincipalCertificate_complete
--- PASS: TestAccUser_threeUsersABC (20.23s)
=== CONT  TestAccServicePrincipalPassword_complete
--- PASS: TestAccGroupDataSource_members (70.02s)
=== CONT  TestAccServicePrincipalCertificate_basic
--- PASS: TestAccUser_complete (16.88s)
=== CONT  TestAccServicePrincipalPassword_basic
--- PASS: TestAccApplicationCertificate_basic (31.64s)
=== CONT  TestAccGroupsDataSource_noNames
--- PASS: TestAccGroupsDataSource_noNames (0.05s)
=== CONT  TestAccServicePrincipalDataSource_byObjectId
--- PASS: TestAccUsersDataSource_byMailNicknamesIgnoreMissing (20.23s)
=== CONT  TestAccGroupsDataSource_byObjectIds
--- PASS: TestAccApplicationCertificate_complete (35.89s)
=== CONT  TestAccServicePrincipalDataSource_byDisplayName
--- PASS: TestAccUser_update (21.98s)
=== CONT  TestAccGroupsDataSource_byUserPrincipalNames
--- PASS: TestAccApplicationDataSource_byApplicationId (24.13s)
=== CONT  TestAccServicePrincipalDataSource_byApplicationId
--- PASS: TestAccUserDataSource_byObjectId (17.38s)
=== CONT  TestAccServicePrincipal_basic
--- PASS: TestAccUser_basic (16.69s)
=== CONT  TestAccUserDataSource_byMailNickname
--- PASS: TestAccApplicationCertificate_requiresImport (32.23s)
=== CONT  TestAccUserDataSource_byObjectIdNonexistent
--- PASS: TestAccUserDataSource_byObjectIdNonexistent (0.70s)
=== CONT  TestAccUserDataSource_byUserPrincipalName
--- PASS: TestAccGroupsDataSource_byObjectIds (16.86s)
=== CONT  TestAccServicePrincipal_update
--- PASS: TestAccGroupsDataSource_byUserPrincipalNames (17.46s)
=== CONT  TestAccServicePrincipal_complete
--- PASS: TestAccApplicationDataSource_byObjectIdComplete (38.42s)
=== CONT  TestAccGroup_preventDuplicateNames
--- PASS: TestAccUserDataSource_byMailNickname (17.51s)
=== CONT  TestAccApplication_appRolesNoValue
--- PASS: TestAccServicePrincipalCertificate_relativeEndDate (48.61s)
=== CONT  TestAccGroup_ownersUpdate
--- PASS: TestAccServicePrincipalDataSource_byApplicationId (30.95s)
=== CONT  TestAccApplication_appRolesUpdate
--- PASS: TestAccUserDataSource_byUserPrincipalName (18.36s)
=== CONT  TestAccGroup_membersUpdate
--- PASS: TestAccServicePrincipalDataSource_byObjectId (34.02s)
=== CONT  TestAccApplication_appRolesDelete
--- PASS: TestAccGroup_preventDuplicateNames (14.36s)
=== CONT  TestAccGroup_ownersDiverse
--- PASS: TestAccServicePrincipalDataSource_byDisplayName (36.10s)
=== CONT  TestAccApplication_nativeUpdate
--- PASS: TestAccServicePrincipalPassword_relativeEndDate (49.09s)
=== CONT  TestAccGroup_membersDiverse
--- PASS: TestAccServicePrincipalCertificate_complete (49.42s)
=== CONT  TestAccGroup_membersAndOwners
--- PASS: TestAccServicePrincipal_basic (35.33s)
=== CONT  TestAccGroup_members
--- PASS: TestAccApplication_appRolesNoValue (18.47s)
=== CONT  TestAccGroup_owners
--- PASS: TestAccServicePrincipalPassword_complete (50.37s)
=== CONT  TestAccGroup_complete
--- PASS: TestAccServicePrincipalPassword_requiresImport (52.93s)
=== CONT  TestAccApplication_nativeReplyUrls
--- PASS: TestAccServicePrincipalCertificate_basic (50.19s)
=== CONT  TestAccGroup_basic
--- PASS: TestAccServicePrincipalPassword_basic (49.90s)
=== CONT  TestAccApplication_native
--- PASS: TestAccServicePrincipal_complete (34.85s)
=== CONT  TestAccServicePrincipalCertificate_requiresImport
--- PASS: TestAccApplication_appRolesDelete (21.81s)
=== CONT  TestAccApplicationAppRole_update
--- PASS: TestAccApplication_nativeReplyUrls (15.28s)
=== CONT  TestAccUserDataSource_byUserPrincipalNameNonexistent
--- PASS: TestAccGroup_basic (15.43s)
=== CONT  TestAccGroupMember_user
--- PASS: TestAccUserDataSource_byUserPrincipalNameNonexistent (0.75s)
=== CONT  TestAccApplication_groupMembershipClaimsUpdate
--- PASS: TestAccApplication_appRolesUpdate (26.06s)
=== CONT  TestAccApplication_appRoles
--- PASS: TestAccServicePrincipal_update (44.86s)
=== CONT  TestAccApplication_availableToOtherTenants
--- PASS: TestAccApplication_native (19.51s)
=== CONT  TestAccGroupMember_multipleUser
--- PASS: TestAccGroup_owners (30.79s)
=== CONT  TestAccApplicationAppRole_complete
--- PASS: TestAccApplication_nativeUpdate (41.39s)
--- PASS: TestAccApplication_appRoles (19.92s)
--- PASS: TestAccGroup_complete (39.87s)
--- PASS: TestAccGroup_ownersDiverse (47.67s)
--- PASS: TestAccApplication_availableToOtherTenants (22.76s)
--- PASS: TestAccApplicationAppRole_update (29.52s)
--- PASS: TestAccApplication_groupMembershipClaimsUpdate (30.38s)
--- PASS: TestAccGroup_membersAndOwners (50.59s)
--- PASS: TestAccApplicationAppRole_complete (21.11s)
--- PASS: TestAccServicePrincipalCertificate_requiresImport (46.50s)
--- PASS: TestAccGroup_members (60.85s)
--- PASS: TestAccGroupMember_user (43.33s)
--- PASS: TestAccGroup_ownersUpdate (78.38s)
--- PASS: TestAccGroup_membersDiverse (73.04s)
--- PASS: TestAccGroupMember_multipleUser (81.00s)
--- PASS: TestAccGroup_membersUpdate (147.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azuread/internal/services/aadgraph	259.627s

…ision avoidance for app_role IDs and oauth2_permission IDs

ghost · 2020-09-03T22:04:06Z

This has been released in version 1.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.0.0"
}
# ... other configuration ...

ghost · 2020-10-04T16:50:24Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

ghost added the size/XXL label Aug 8, 2020

manicminer added breaking-change documentation refactor labels Aug 8, 2020

manicminer force-pushed the release/1.0 branch 3 times, most recently from 7a781da to dcb3616 Compare August 8, 2020 02:50

manicminer added this to the v1.0.0 milestone Aug 8, 2020

manicminer force-pushed the release/1.0 branch 2 times, most recently from d4ac092 to 71c788c Compare August 13, 2020 18:32

manicminer force-pushed the release/1.0 branch from 71c788c to ce1ae8a Compare August 13, 2020 18:39

move tests up one level

ccb2e53

katbyte force-pushed the release/1.0 branch from bede06a to ccb2e53 Compare August 14, 2020 02:24

Fix invalid test resource refs

c16aed5

manicminer added the feature/applications label Aug 14, 2020

manicminer and others added 13 commits August 14, 2020 18:17

Tidy up some test names

25906cd

update provider/client configuration

82e125c

Merge branch 'release/1.0' of github.com:terraform-providers/terrafor…

35ff992

…m-provider-azuread into release/1.0

make compile

84a549f

fix some acctests

f058f20

refactor function names

089dab1

move helpers into interal

3702117

Revert leftover O+C experiment

1364181

data.azuread_group: name argument is now case insensitive (closes #291)

5f8ebbd

Refresh readme

0f6873f

Linting, fix up makefile

a6924cc

Fix website test

f6cb6fe

manicminer added the feature/groups label Aug 17, 2020

manicminer added 11 commits August 28, 2020 04:00

Drying out

0662cbd

Fix length check, improve error messages

553a896

Always set state values, they can be nil!

a4b94e6

Never create duplicate passwords/certificates

e78b6e4

Resource funcs can be private

62b604b

Prefer to pass []interface{}

00b7c21

Tidy up some more error messages

c14f515

Drop unnecessary nil check

8ace35f

Use WaitForState() to effect group member removal (works around API i…

e893214

…ssues where DELETE requests are sometimes not honoured)

Better error handling when adding duplicate app roles, oauth2 permiss…

fa3aea0

…ions, and application/service principal passwords and certificates

Use Go 1.13 for now

d045b98

manicminer requested a review from tombuildsstuff August 28, 2020 16:12

manicminer added 9 commits September 1, 2020 17:21

Revert to Go 1.13.15

1f6fc70

Avoid crash, improve error reporting

fb60af5

Func name typo

b1458e0

Import detection for existing group members

4df5aaf

Ensure state upgrade funcs return a snapshot in time of the schema

70d9c0a

Import resource ID validation, dry out credential ID validation, coll…

9e3843b

…ision avoidance for app_role IDs and oauth2_permission IDs

Avoid missing attribute if blank/nil

92fe0ff

check IDs for blank string on create

7a31dd1

add missing newlines

0ce07a1

This was referenced Sep 3, 2020

azuread_application: no longer derive a default value for the homepage property #278

Closed

data.azuread_group: name argument is now case insensitive #291

Closed

manicminer merged commit b74f81a into master Sep 3, 2020

manicminer added a commit that referenced this pull request Sep 3, 2020

update changelog for #298

d3a67b1

ghost locked as resolved and limited conversation to collaborators Oct 4, 2020

manicminer deleted the release/1.0 branch October 4, 2020 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare for v1.0 release #298

Prepare for v1.0 release #298

manicminer commented Aug 8, 2020 •

edited

Loading

manicminer commented Aug 28, 2020

ghost commented Sep 3, 2020

ghost commented Oct 4, 2020

Prepare for v1.0 release #298

Prepare for v1.0 release #298

Conversation

manicminer commented Aug 8, 2020 • edited Loading

Summary

CHANGELOG

manicminer commented Aug 28, 2020

ghost commented Sep 3, 2020

ghost commented Oct 4, 2020

manicminer commented Aug 8, 2020 •

edited

Loading