Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications schema - add on_premise_security_identifier #463

Closed

Conversation

kaovd
Copy link

@kaovd kaovd commented Jun 15, 2021

Resolves #462

Ran the following tests seems to all work fine.
image

> $ TF_ACC=1 go test -v -timeout=2h ./internal/services/applications -run="TestAccApplication_complete"                                                     
=== RUN   TestAccApplication_complete
=== PAUSE TestAccApplication_complete
=== CONT  TestAccApplication_complete
--- PASS: TestAccApplication_complete (84.10s)
PASS
ok      github.com/hashicorp/terraform-provider-azuread/internal/services/applications  84.113s

@manicminer
Copy link
Member

Hi @kaovd, thanks for the suggestion! As there's a lot of change going on right now in preparation for v2.0, I've cherry-picked your change into #474 with attribution, so I'll go ahead and close this PR as it'll be merged in that one. Thanks again!

@manicminer manicminer closed this Jun 30, 2021
@manicminer manicminer reopened this Jul 2, 2021
@manicminer manicminer closed this Jul 2, 2021
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App registration should accept on_premise_security_identifier as additional property
2 participants