Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_gremlin_graph: Expose default_ttl #10159

Merged
merged 2 commits into from Jan 14, 2021

Conversation

jackbatzner
Copy link
Contributor

Support for default_ttl on azurerm_cosmosdb_gremlin_graph

Fixes #10123

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Brunhil - overall this looks good, but should we not be reading the value back in during read?

@jackbatzner
Copy link
Contributor Author

@katbyte - That should be fixed now. Good catch, I thought I was missing something 😅

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Brunhil - LGTM now 😄

@katbyte katbyte added this to the v2.43.0 milestone Jan 14, 2021
@katbyte katbyte merged commit b988b96 into hashicorp:master Jan 14, 2021
katbyte added a commit that referenced this pull request Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Feb 13, 2021
@jackbatzner jackbatzner deleted the gremlin-default-ttl branch March 2, 2021 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for default_ttl on azurerm_cosmosdb_gremlin_graph
2 participants