Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Route Circuit (Microsoft Peering) Missing Arguments. #1084

Closed
rafael6 opened this issue Apr 5, 2018 · 4 comments · Fixed by #6596
Closed

Express Route Circuit (Microsoft Peering) Missing Arguments. #1084

rafael6 opened this issue Apr 5, 2018 · 4 comments · Fixed by #6596

Comments

@rafael6
Copy link

rafael6 commented Apr 5, 2018

Terraform Version

0.11.6

Affected Resource(s)

express_route_circuit_pering (Microsoft Peering)

Terraform Configuration Files

resource "azurerm_express_route_circuit_peering" "test" {
  peering_type                  = "MicrosoftPeering"
  express_route_circuit_name    = "${azurerm_express_route_circuit.test.name}"
  resource_group_name           = "${azurerm_resource_group.test.name}"
  peer_asn                      = 100
  primary_peer_address_prefix   = "123.0.0.0/30"
  secondary_peer_address_prefix = "123.0.0.4/30"
  vlan_id                       = 300

  microsoft_peering_config {
    advertised_public_prefixes = ["123.1.0.0/24"]
  }
}

Debug Output

N/A

Panic Output

N/A

Expected Behavior

Support for the following arguments related to Azurerm Express Route Circuit Peering (Microsoft Peering):

-PeerAddressType
-MicrosoftConfigCustomerAsn
-MicrosoftConfigRoutingRegistryName

https://docs.microsoft.com/en-us/azure/expressroute/expressroute-howto-routing-arm#next-steps

Actual Behavior

I don't see documentation or support for the following Azurerm Express Route Circuit Peering (Microsoft Peering) arguments:

-PeerAddressType
-MicrosoftConfigCustomerAsn
-MicrosoftConfigRoutingRegistryName

Steps to Reproduce

N/A

Important Factoids

N/A

References

Below is a powershell script with PeerAddressType, MicrosoftConfigCustomerAsn, and MicrosoftConfigRoutingRegistryName arguments:

Add-AzureRmExpressRouteCircuitPeeringConfig
-Name "MicrosoftPeering"
-ExpressRouteCircuit $ckt
-PeeringType MicrosoftPeering
-PeerASN 100
-PeerAddressType IPv4
-PrimaryPeerAddressPrefix "123.0.0.0/30"
-SecondaryPeerAddressPrefix "123.0.0.4/30"
-VlanId 300
-MicrosoftConfigAdvertisedPublicPrefixes "123.1.0.0/24"
-MicrosoftConfigCustomerAsn 23
-MicrosoftConfigRoutingRegistryName "ARIN"

https://docs.microsoft.com/en-us/azure/expressroute/expressroute-howto-routing-arm#next-steps

@tombuildsstuff tombuildsstuff changed the title AzureRm Express Route Circuit (Microsoft Peering) Missing Arguments. Express Route Circuit (Microsoft Peering) Missing Arguments. Nov 2, 2018
@mashbynz
Copy link

This is still an issue.

Terraform v0.12.5

Currently unable to configure peerings as I receive the following error message:

Error: network.ExpressRouteCircuitPeeringsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="ExpressRouteMicrosoftPeeringConfigIncomplete" Message="The Express Route Microsoft Peering /subscriptions/ef3df766-183a-45cd-aa69-xxxxxx/resourceGroups/prodsharedservices1-rg/providers/Microsoft.Network/expressRouteCircuits/prodsharedservices1-ergw/peerings/MicrosoftPeering config for Protocol Ipv4 is incomplete.." Details=[]

if the microsoft_config_routing_registry_name parameter as part of the microsoft_peering_config block is not completed. This parameter is unable to be enetered as terraform does not recognise the parameter.

@pearcec
Copy link
Contributor

pearcec commented Apr 23, 2020

So looks like the following are missing? I will take a look at adding them.
-MicrosoftConfigCustomerAsn 23
-MicrosoftConfigRoutingRegistryName "ARIN"

pearcec pushed a commit to pearcec/terraform-provider-azurerm that referenced this issue Apr 23, 2020
Fixing issue hashicorp#1084 Microsoft Peering is missing customer_asn and routing_registry_name
- Test included
- Website updated
@katbyte katbyte added this to the v2.8.0 milestone Apr 26, 2020
katbyte pushed a commit that referenced this issue Apr 26, 2020
…g_registry_name #1084 (#6596)

Fixing issue #1084 Microsoft Peering is missing customer_asn and routing_registry_name

Test included
Website updated
(fixes #1084)
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants