Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: upgrading github.com/hashicorp/terraform-plugin-sdk to v1.17.1 #11431

Merged
merged 3 commits into from Apr 23, 2021

Conversation

tombuildsstuff
Copy link
Member

This fixes binary testing when using Terraform Core 0.15

@tombuildsstuff tombuildsstuff added dependencies upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc) labels Apr 22, 2021
@tombuildsstuff tombuildsstuff added this to the v2.57.0 milestone Apr 22, 2021
@tombuildsstuff tombuildsstuff requested a review from a team April 22, 2021 08:40
@ghost ghost added the size/XXL label Apr 22, 2021
@tombuildsstuff tombuildsstuff marked this pull request as draft April 22, 2021 08:48
@tombuildsstuff
Copy link
Member Author

Blocked on hashicorp/terraform-plugin-sdk#747

@tombuildsstuff tombuildsstuff changed the title dependencies: upgrading github.com/hashicorp/terraform-plugin-sdk to v1.17.0 dependencies: upgrading github.com/hashicorp/terraform-plugin-sdk to v1.17.1 Apr 22, 2021
@tombuildsstuff
Copy link
Member Author

Tests pass on 0.15:

$ TF_ACC=1 go test -v ./azurerm/internal/services/resource/... -run=TestAccResourceGroup_basic
2021/04/22 17:56:28 [DEBUG] not using binary driver name, it's no longer needed
2021/04/22 17:56:29 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccResourceGroup_basic
=== PAUSE TestAccResourceGroup_basic
=== CONT  TestAccResourceGroup_basic
--- PASS: TestAccResourceGroup_basic (131.80s)
PASS

@tombuildsstuff tombuildsstuff marked this pull request as ready for review April 22, 2021 15:59
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit f4d2562 into master Apr 23, 2021
@tombuildsstuff tombuildsstuff deleted the deps/plugin-sdk-v1.17 branch April 23, 2021 06:47
@tombuildsstuff
Copy link
Member Author

Tests look good on 0.14 & in CI too

tombuildsstuff added a commit that referenced this pull request Apr 23, 2021
katbyte added a commit that referenced this pull request Apr 27, 2021
alvintang pushed a commit to alvintang/terraform-provider-azurerm that referenced this pull request Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies size/XXL upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants