add: eventgrid_domain data source, test, docs #13033
Conversation
Hjortsberg
changed the title
There was a problem hiding this comment.
Thanks for the pr @Hjortsberg - overall looks good and i've left some comments inline and the linters have called out the schema changes required
| return fmt.Errorf("making Read request on EventGrid Domain '%s': %+v", name, err) | ||
| } | ||
|
|
||
| d.SetId(*resp.ID) |
There was a problem hiding this comment.
we should be nil checking ID here
| type EventGridDomainDataSource struct { | ||
| } | ||
|
|
||
| func TestAccEventGridDomainDataSource_basic(t *testing.T) { |
There was a problem hiding this comment.
we can probably remove the other tests, usually we just have a single data source test
|
@Hjortsberg since we haven't heard anything back yet i'm going to jump in here and finish up this PR so that your work can be merged and released to the community. |
|
@stephybun, sorry for the lack of replies from me. I greatly appreciate the contribution here, thank you. |
|
This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This is a proposal to fix #13008.
The implementation is untested.
This is my first PR to this repo, please be constructive in the feedback so that I can improve. :)