azurerm_function_app & azurerm_app_service - support for vnet_route_all_enabled

[henrymcconville]

Fixes #13259, inspired by #13073

Acceptance Tests:

➜  ~/go/src/github.com/hashicorp/terraform-provider-azurerm: git:(function-app-vnet-route-all) ✗ make acctests SERVICE='web' TESTARGS='-run=VnetRouteAllEnabled'
 TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/web -run=VnetRouteAllEnabled -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled
=== PAUSE TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled
=== RUN   TestAccFunctionApp_siteConfigVnetRouteAllEnabled
=== PAUSE TestAccFunctionApp_siteConfigVnetRouteAllEnabled
=== RUN   TestAccFunctionApp_appSettingsVnetRouteAllEnabled
=== PAUSE TestAccFunctionApp_appSettingsVnetRouteAllEnabled
=== CONT  TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled
=== CONT  TestAccFunctionApp_appSettingsVnetRouteAllEnabled
=== CONT  TestAccFunctionApp_siteConfigVnetRouteAllEnabled
--- PASS: TestAccFunctionApp_siteConfigVnetRouteAllEnabled (151.79s)
--- PASS: TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled (154.94s)
--- PASS: TestAccFunctionApp_appSettingsVnetRouteAllEnabled (216.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/web	218.560s

[tdever42]

I'm waiting for this so I can start deploying my function apps with terraform. Thanks for getting it done!

[piwi91]

This should also be added to the azurerm_app_service resource

[jackofallops]

Hi @henrymcconville - Thanks for this, it looks good, if you can resolve the conflicts I'll run it through tests and get it approved / merged.

[henrymcconville]

Thanks @jackofallops! Conflicts resolved and acc tests are still passing:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/web -run=VnetRouteAllEnabled -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled
=== PAUSE TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled
=== RUN   TestAccFunctionApp_siteConfigVnetRouteAllEnabled
=== PAUSE TestAccFunctionApp_siteConfigVnetRouteAllEnabled
=== RUN   TestAccFunctionApp_appSettingsVnetRouteAllEnabled
=== PAUSE TestAccFunctionApp_appSettingsVnetRouteAllEnabled
=== CONT  TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled
=== CONT  TestAccFunctionApp_appSettingsVnetRouteAllEnabled
=== CONT  TestAccFunctionApp_siteConfigVnetRouteAllEnabled
--- PASS: TestAccFunctionAppDataSource_siteConfigVnetRouteAllEnabled (155.38s)
--- PASS: TestAccFunctionApp_appSettingsVnetRouteAllEnabled (165.74s)
--- PASS: TestAccFunctionApp_siteConfigVnetRouteAllEnabled (183.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/web	185.315s

[katbyte]

Thanks @henrymcconville - LGTM now 🙌

[github-actions]

This functionality has been released in v2.78.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.