Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage_blob): implement cache_control #13946

Merged
merged 3 commits into from Nov 2, 2021
Merged

feat(storage_blob): implement cache_control #13946

merged 3 commits into from Nov 2, 2021

Conversation

secustor
Copy link
Contributor

Fixes #6236

Adds the ability to set cache_control for blobs in a storage_account

@secustor
feat(storage_blob): implement control_cache
89105ae 
Signed-off-by: secustor <sebastian@poxhofer.at>
tombuildsstuff
tombuildsstuff requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @secustor

Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up (and the tests pass) then this should otherwise be good to merge 👍

Thanks!

internal/services/storage/storage_blob_resource_test.go Outdated Show resolved Hide resolved
internal/services/storage/storage_blob_resource_test.go Outdated Show resolved Hide resolved
internal/services/storage/storage_blob_resource.go Show resolved Hide resolved
internal/services/storage/storage_blob_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_blob_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_blob_resource.go Outdated Show resolved Hide resolved
secustor and others added 2 commits October 28, 2021 19:13
@secustor @tombuildsstuff
Apply suggestions from code review
07ae6b4 
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@secustor
fix test, and add docs
519be0a 
Signed-off-by: secustor <sebastian@poxhofer.at>
@secustor
Copy link
Contributor Author

secustor commented Oct 28, 2021 •
edited

Seems like the lint job has simply timed out. Could you restart this job?

@secustor
Copy link
Contributor Author

secustor commented Nov 2, 2021

@tombuildsstuff Is anything still missing? The unit tests have successfully ran trough

@katbyte katbyte added this to the v2.84.0 milestone Nov 2, 2021
katbyte
katbyte approved these changes Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @secustor - LGTM 🏗️

@katbyte katbyte merged commit a0bed81 into hashicorp:main Nov 2, 2021
katbyte added a commit that referenced this pull request Nov 2, 2021
@katbyte
CHANGELOG.md for #13946
9056bdb
@katbyte katbyte changed the title feat(storage_blob): implement control_cache feat(storage_blob): implement cache_control Nov 2, 2021
@secustor secustor deleted the implement_cache_control branch November 3, 2021 05:49
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation enhancement service/storage size/M
Projects
None yet
Milestone
v2.84.0
Development

Successfully merging this pull request may close these issues.

Feature request: Set cache control for Storage Account Blob
3 participants
@secustor @tombuildsstuff @katbyte