-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage_blob): implement cache_control #13946
Conversation
Signed-off-by: secustor <sebastian@poxhofer.at>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @secustor
Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up (and the tests pass) then this should otherwise be good to merge 👍
Thanks!
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Signed-off-by: secustor <sebastian@poxhofer.at>
Seems like the lint job has simply timed out. Could you restart this job? |
@tombuildsstuff Is anything still missing? The unit tests have successfully ran trough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @secustor - LGTM 🏗️
This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #6236
Adds the ability to set
cache_control
for blobs in astorage_account