Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpubsub: refactoring to use go-azure-sdk #18892

Merged
merged 5 commits into from
Nov 1, 2022
Merged

webpubsub: refactoring to use go-azure-sdk #18892

merged 5 commits into from
Nov 1, 2022

Conversation

tombuildsstuff
Copy link
Contributor

No description provided.

@tombuildsstuff tombuildsstuff added this to the v3.29.0 milestone Oct 20, 2022
mbfrahry
mbfrahry requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly looking good minus some errors for azurerm_web_pubsub_network_acl

internal/services/signalr/web_pubsub_network_acl_resource.go

future, err := client.Update(ctx, existing, id.ResourceGroup, id.WebPubSubName)
if err != nil {
if err := client.UpdateThenPoll(ctx, *id, payload); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting test failures here. I did some digging and the body being sent to the api is nil.

Error: updating Network ACL configuration for "Web Pub Sub (Subscription: \"*******\"\nResource Group Name: \"acctestRG-webpubsub-XXXXXXX\"\nResource Name: \"acctestRG-webpubsub-XXXXXX\")": performing Update: webpubsub.WebPubSubClient#Update: Failure sending request: StatusCode=0 -- Original Error: Code="InvalidResource" Message="The resource definition is invalid."

@katbyte katbyte modified the milestones: v3.29.0, v3.30.0 Oct 28, 2022
stephybun
stephybun approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needed a rebase
image

@stephybun stephybun merged commit c328da6 into main Nov 1, 2022
@stephybun stephybun deleted the refactor/web-pub-sub branch November 1, 2022 13:48
stephybun added a commit that referenced this pull request Nov 1, 2022
@stephybun
Update for #18892
879154e
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry requested changes

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
dependencies service/signalr size/XL
Projects
None yet
Milestone
v3.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tombuildsstuff @mbfrahry @stephybun @katbyte