Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mssql_virtual_machine - support system_db_on_data_disk_enabled #19115

Merged
merged 1 commit into from
Nov 3, 2022
Merged

azurerm_mssql_virtual_machine - support system_db_on_data_disk_enabled #19115

merged 1 commit into from
Nov 3, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Nov 3, 2022

Fix #18377

@myc2h6o myc2h6o mentioned this pull request Nov 3, 2022
Closed
1 task
@myc2h6o
Copy link
Contributor Author

myc2h6o commented Nov 3, 2022

Test result
image

myc2h6o
myc2h6o commented Nov 3, 2022
View reviewed changes
internal/services/mssql/mssql_virtual_machine_resource_test.go
@@ -675,6 +697,10 @@ resource "azurerm_mssql_virtual_machine" "test" {
log_file_size_mb = 512
}
}

depends_on = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sql VM should be depending on the data disk attachment so as to configure the storage configuration.

katbyte
katbyte approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧾

@katbyte katbyte merged commit 873648f into hashicorp:main Nov 3, 2022
katbyte added a commit that referenced this pull request Nov 3, 2022
@katbyte
CHANGELOG #19115
c364452
@github-actions github-actions bot added this to the v3.30.0 milestone Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@myc2h6o myc2h6o deleted the sql_systemdb branch November 4, 2022 06:53
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/mssql Microsoft SQL Server size/M
Projects
None yet
Milestone
v3.30.0
Development

Successfully merging this pull request may close these issues.

Support for azurerm_mssql_virtual_machine to Set system databases location to newly create data storage
2 participants
@myc2h6o @katbyte