Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_postgresql_flexible_server: add default value for authentication.active_directory_auth_enabled and authentication.password_auth_enabled #20054

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Jan 17, 2023

When the block authentication is not specified, the service will default these values to authentication.active_directory_auth_enabled=false and authentication.password_auth_enabled=true.
while when the block authentication is specified but authentication.password_auth_enabled is NOT specified, provider will default it to false. So add default values for them.

…and `authentication.password_auth_enabled`
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ziyeqf - This appears to be related to the same things as #20052 - can you take a look at the feedback on that one so we can look to close this one?

Thanks!

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Jan 18, 2023

Hi @jackofallops , I can merge this PR to #20052 to merge togther. While I'm not sure if there is anyway to solve this at plan time expect adding default.

It's ready to review now.

@ziyeqf ziyeqf changed the title add default value for authentication.active_directory_auth_enabled and authentication.password_auth_enabled azurerm_postgresql_flexible_server: add default value for authentication.active_directory_auth_enabled and authentication.password_auth_enabled Jan 20, 2023
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 7c8abd9 into hashicorp:main Jan 31, 2023
@mbfrahry mbfrahry added this to the v3.42.0 milestone Jan 31, 2023
mbfrahry added a commit that referenced this pull request Jan 31, 2023
@ziyeqf ziyeqf deleted the tengzh/psql/default branch February 1, 2023 02:01
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This functionality has been released in v3.42.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants