azurerm_postgresql_flexible_server - fix a potential panic

[ziyeqf]

It will panic when authentication is specified with empty block. add a runtime check for it

[jackofallops]

Hi @ziyeqf - Thanks for this PR.
I think we could approach this a different way to assist users by catching the problem at plan time, and ensuring that the block cannot be empty by using schema constraints, for example:

							AtLeastOneOf: []string{
								"authentication.0.active_directory_auth_enabled",
								"authentication.0.password_auth_enabled",
								"authentication.0.tenant_id",
							},

on each item in authentication, WDYT?

[ziyeqf]

Hi @ziyeqf - Thanks for this PR. I think we could approach this a different way to assist users by catching the problem at plan time, and ensuring that the block cannot be empty by using schema constraints, for example:

							AtLeastOneOf: []string{
								"authentication.0.active_directory_auth_enabled",
								"authentication.0.password_auth_enabled",
								"authentication.0.tenant_id",
							},

on each item in authentication, WDYT?

Make sense, code updated, thanks!

[jackofallops]

Hi @ziyeqf
Thanks for making those changes, LGTM 👍

Misread changes.

[jackofallops]

Thanks @ziyeqf
Apologies for the mistaken approval earlier, my mistake, hadn't had coffee yet 🙈 .
wrt combining with #20054, only one of these fixes should be required, hence asking to consider rolling them up / closing one. Both would result in guarding users against providing an invalid config. The simplest would be to set default: true on password_auth_enabled, so I think we should close this one, and run with/merge 20054?

[jackofallops]

This should be on each of the properties inside the block, so below would look like:

						"active_directory_auth_enabled": {
							Type:     pluginsdk.TypeBool,
							Optional: true,
							AtLeastOneOf: []string{
								"authentication.0.active_directory_auth_enabled",
								"authentication.0.password_auth_enabled",
							},
						},
						"password_auth_enabled": {
							Type:     pluginsdk.TypeBool,
							Optional: true,
							AtLeastOneOf: []string{
								"authentication.0.active_directory_auth_enabled",
								"authentication.0.password_auth_enabled",
							},
						},
						"tenant_id": {
							Type:         pluginsdk.TypeString,
							Optional:     true,
							ValidateFunc: validation.IsUUID,
							RequiredWith: []string{
								"authentication.0.active_directory_auth_enabled",
							},
						},
					},

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.