azurerm_spring_cloud_gateway - support for the allowed_origin_patterns property
#22317
Conversation
ms-henglu
commented
Jun 29, 2023
•
ms-henglu
commented
…erns`, `addon_json` properties
There was a problem hiding this comment.
Hi @ms-henglu
Thanks for this PR. I think we need to be explicit in the values for this new property and create an appropriate schema block for it. Please see the comment below and we can take another look when that is addressed.
Thanks!
| @@ -58,6 +59,13 @@ func resourceSpringCloudGateway() *pluginsdk.Resource { | |||
| ValidateFunc: validate.SpringCloudServiceID, | |||
| }, | |||
|
|
|||
| "addon_json": { | |||
There was a problem hiding this comment.
I think we should be explicit here for the currently supported configuration, not arbitrary JSON. The fact that it is noted to be subject to change in the docs in future is not really any different to any other API parameter. We have known supported values today, and have the ability to update/deprecate etc in future as with any other property or set of properties.
There was a problem hiding this comment.
Got it, I've removed this addon_json field. Please take another look, thanks!
ms-henglu
changed the title
azurerm_spring_cloud_gateway - support for the allowed_origin_patterns, addon_json propertiesazurerm_spring_cloud_gateway - support for the allowed_origin_patterns property
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
