-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_spring_cloud_gateway
- support for the allowed_origin_patterns
property
#22317
azurerm_spring_cloud_gateway
- support for the allowed_origin_patterns
property
#22317
Conversation
ms-henglu
commented
Jun 29, 2023
•
edited
Loading
edited
…erns`, `addon_json` properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ms-henglu
Thanks for this PR. I think we need to be explicit in the values for this new property and create an appropriate schema block for it. Please see the comment below and we can take another look when that is addressed.
Thanks!
@@ -58,6 +59,13 @@ func resourceSpringCloudGateway() *pluginsdk.Resource { | |||
ValidateFunc: validate.SpringCloudServiceID, | |||
}, | |||
|
|||
"addon_json": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be explicit here for the currently supported configuration, not arbitrary JSON. The fact that it is noted to be subject to change in the docs in future is not really any different to any other API parameter. We have known supported values today, and have the ability to update/deprecate etc in future as with any other property or set of properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I've removed this addon_json
field. Please take another look, thanks!
azurerm_spring_cloud_gateway
- support for the allowed_origin_patterns
, addon_json
propertiesazurerm_spring_cloud_gateway
- support for the allowed_origin_patterns
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💾
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |