Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Public IP Prefixes #2239

Closed
rhnewtron opened this issue Nov 5, 2018 · 7 comments · Fixed by #3139
Closed

Support Public IP Prefixes #2239

rhnewtron opened this issue Nov 5, 2018 · 7 comments · Fixed by #3139

Comments

@rhnewtron
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Azure terraform provider does not support Azure Public IP Prefixes. Please support them. This would mean:

  • I can create azure public ip prefixes
  • I can create azurerm public ip's (standard) referencing the azure public ip prefix created before

This make on premise firewalling for larger clusters with a lot of NAT (e.g. Kubernetes/Openshift) easier.

New or Affected Resource(s)

  • azurerm_public_ip_prefix
  • azurerm_public_ip (modified, add support to create from azurerm_public_ip_prefix)

References

@katbyte
Copy link
Collaborator

katbyte commented Dec 7, 2018

depends on #2433

@katbyte katbyte added this to the 1.21.0 milestone Dec 7, 2018
@katbyte katbyte self-assigned this Dec 7, 2018
@pixelicous

This comment has been minimized.

@katbyte katbyte removed this from the 1.21.0 milestone Jan 1, 2019
@pixelicous
Copy link

seems like #2433 is merged.. any chance this can be re-entered into the 1.21 milestone :)

Currently we are using data sources for a public ip prefix we create manually in the portal

@katbyte katbyte removed their assignment Feb 8, 2019
@steve-hawkins
Copy link
Contributor

steve-hawkins commented Mar 28, 2019

@pixelicous I have started to take a look at adding these resources today:-

azurerm_public_ip_prefix
azurerm_public_ip_prefix_association

had to update azurerm_public_ip rather than creating an association virtual resource as the public IP API will not allow updates to IP prefix

@pixelicous
Copy link

@steve-hawkins Hey! thanks for this! I understand what you mean, when creating ip address in the prefix you cannot choose which prefix it will be, very idiotic design decision imo, it also doesnt work very well in terraform, sometimes when generating it will skip a public ip that was created and deleted.

Again, thanks for your time, wish i knew GO or had time to learn/handle it myself..

katbyte pushed a commit that referenced this issue Apr 15, 2019
This should fulfil Issue #2239 

(fixes #2239)
@katbyte katbyte added this to the v1.25.0 milestone Apr 15, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants