azurerm_cognitive_deployment - Add support for VersionUpgradeOption
#22520
Conversation
There was a problem hiding this comment.
Hey @lonegunmanb, this change is a good start but we should write a test for this as well. It also looks like the API defaults this value to OnceNewDefaultVersionAvailable so we'll want to account for that as well
|
Roger that, will do |
|
Hi @mbfrahry I have to change the model used in e2e test since the original model is deprecated now. Would you please give this pr a review? Thanks! |
|
@lonegunmanb Thanks for updating the tests. It looks like the model got reverted to the older one when |
Whoops... My bad, I must mess it up when I tried to merge the code, thanks for pointing out. |
… version they like
|
Hi @manicminer @mbfrahry I've rebased the pr to the latest main branch, and I've upgraded the model version in the e2e test so all acc tests could pass on my side. Would you please give this r another review? Thanks! |
|
Thanks @lonegunmanb. I'm getting a test failure with a 400 response. 
|
|
I'll see what I can do to solve this testing issue. |
|
Hi @manicminer I've tried to switch the region but still got no luck. I've checked the team city's history, the same errors occurred before on the main branch. The tests got the green light on our testing subscription: Could we approve this pr for now? Or maybe we need to open a support ticket on your side I guess? Anyway, thanks for reading, waiting for your further instructions. |
|
@lonegunmanb We need to be able to test this. It looks like we'll have to submit an application for access to the service |
|
Hello @manicminer , Is there any timeline for when this can be verified and merged? We are currently blocked with this. As there is no way for us to upgrade to a new version. Is there any way we can help ? Thanks! |
|
@manicminer is there any way we could help with testing? |
|
Hello @mbfrahry, |
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/azurerm" updated from "3.79.0" to
"3.80.0" in file ".terraform.lock.hcl"</p>
<details>
<summary>3.80.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.80.0
ENHANCEMENTS:

*
`internal/sdk` - Added support for pointer Types in resource models
([#23810](https://github.com/hashicorp/terraform-provider-azurerm/issues/23810))
*
dependencies: updating to `v0.63.0` of
`github.com/hashicorp/go-azure-helpers`
([#23785](https://github.com/hashicorp/terraform-provider-azurerm/issues/23785))
*
dependencies: updating to `v0.20231106.1151347` of
`github.com/hashicorp/go-azure-sdk`
([#23787](https://github.com/hashicorp/terraform-provider-azurerm/issues/23787))
*
`azurerm_cognitive_deployment` - support for the
`version_upgrade_option` property
([#22520](https://github.com/hashicorp/terraform-provider-azurerm/issues/22520))
*
`azurerm_firewall_policy_rule_collection_group` - add support for the
property `http_headers`
([#23641](https://github.com/hashicorp/terraform-provider-azurerm/issues/23641))
*
`azurerm_kubernetes_cluster` - `fips_enabled` can be updated in the
`default_node_pool` without recreating the cluster
([#23612](https://github.com/hashicorp/terraform-provider-azurerm/issues/23612))
*
`azurerm_kusto_cluster` - the cluster `name` can now include dashes
([#23790](https://github.com/hashicorp/terraform-provider-azurerm/issues/23790))
*
`azurerm_postgresql_database` - update the validation of `collation` to
include support for `French_France.1252`
([#23783](https://github.com/hashicorp/terraform-provider-azurerm/issues/23783))

BUG
FIXES:

* Data Source: `azurerm_data_protection_backup_vault` -
removing `import` support, since Data Sources don't support being
imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))
*
Data Source: `azurerm_kusto_database` - removing `import` support, since
Data Sources don't support being imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))
*
Data Source: `azurerm_virtual_hub_route_table` - removing `import`
support, since Data Sources don't support being imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))


</pre>
</details>
</details>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Hey @mbfrahry May I know from where this default is defined? From the doc
I can raise a PR for a quick fix. Do let me know thoughts @katbyte |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add support for VersionUpgradeOption so the users can set the model's version they like. This pr should fix #22501 .