Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_web_app, azurerm_windows_web_app_slot, azurerm_linux_web_app, azurerm_linux_web_app_slot, azurerm_windows_function_app, azurerm_windows_function_app_slot, azurerm_linux_function_app, azurerm_linux_function_app_slot - add runtime update #24073

Merged
merged 11 commits into from
Mar 11, 2024

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Nov 30, 2023

  1. Add support for runtime stack - node and dotnet
    azurerm_windows_web_app, azurerm_windows_web_app_slot: add ~20 for node_version in application_stack
    azurerm_linux_web_app, azurerm_linux_web_app_slot: add 8.0 for dotnet_version & 20-lts for node_version in application_stack
    azurerm_windows_function_app, azurerm_windows_function_app_slot: add ~20 for node_version in application_stack
    azurerm_linux_function_app, azurerm_linux_function_app_slot: add 20 for node_version in application_stack

resolve issue:#23528

@xiaxyi xiaxyi changed the title azurerm_windows_web_app, azurerm_windows_web_app_slot, azurerm_linux_web_app, azurerm_linux_web_app_slot, azurerm_windows_function_app, azurerm_windows_function_app_slot, azurerm_linux_function_app, azurerm_linux_function_app_slot, azurerm_windows_web_app, azurerm_windows_web_app_slot, azurerm_linux_web_app, azurerm_linux_web_app_slot, azurerm_windows_function_app, azurerm_windows_function_app_slot, azurerm_linux_function_app, azurerm_linux_function_app_slot - add runtime update Nov 30, 2023
@joshvito
Copy link
Contributor

joshvito commented Dec 7, 2023

Came here looking to implement 20-lts, Thanks Friends!

@petergoldstein
Copy link

@xiaxyi Is there anything blocking this being merged in the next patch version? It's been open for a bit.

@rcskosir rcskosir linked an issue Jan 8, 2024 that may be closed by this pull request
1 task
@xanderdeseyn
Copy link

We are also waiting on this. Any release date in sight?

@LordA98
Copy link

LordA98 commented Jan 22, 2024

We are also waiting on this. Is there an update on when this will be merged?

@francisceril
Copy link

What's the update for this? Neither 18-lts nor 20-lts work.

@katbyte
Copy link
Collaborator

katbyte commented Feb 6, 2024

Now that the API has been updated can you please resolve the conflicts here?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the tests:

------- Stdout: -------
=== RUN   TestAccLinuxWebApp_requiresImport
=== PAUSE TestAccLinuxWebApp_requiresImport
=== CONT  TestAccLinuxWebApp_requiresImport
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating App Service Plan (Subscription: "*******"
        Resource Group Name: "acctestRG-240209200140996370"
        Server Farm Name: "acctestASP-240209200140996370"): performing CreateOrUpdate: unexpected status 409 with response: {"Code":"Conflict","Message":"The pricing tier 'Basic' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed","Target":null,"Details":[{"Message":"The pricing tier 'Basic' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed"},{"Code":"Conflict"},{"ErrorEntity":{"ExtendedCode":"04114","MessageTemplate":"The pricing tier '{0}' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed","Parameters":["Basic"],"Code":"Conflict","Message":"The pricing tier 'Basic' is not allowed in this resource group. Use this link to learn more: https://aka.ms/app-service-plan-scale-not-allowed"}}],"Innererror":null}
        
          with azurerm_service_plan.test,
          on terraform_plugin_test.tf line 28, in resource "azurerm_service_plan" "test":
          28: resource "azurerm_service_plan" "test" {
        
        creating App Service Plan (Subscription:
        "*******"
        Resource Group Name: "acctestRG-240209200140996370"
        Server Farm Name: "acctestASP-240209200140996370"): performing
        CreateOrUpdate: unexpected status 409 with response:
        {"Code":"Conflict","Message":"The pricing tier 'Basic' is not allowed in this
        resource group. Use this link to learn more:
        https://aka.ms/app-service-plan-scale-not-allowed","Target":null,"Details":[{"Message":"The
        pricing tier 'Basic' is not allowed in this resource group. Use this link to
        learn more:
        https://aka.ms/app-service-plan-scale-not-allowed"},{"Code":"Conflict"},{"ErrorEntity":{"ExtendedCode":"04114","MessageTemplate":"The
        pricing tier '{0}' is not allowed in this resource group. Use this link to
        learn more:
        https://aka.ms/app-service-plan-scale-not-allowed","Parameters":["Basic"],"Code":"Conflict","Message":"The
        pricing tier 'Basic' is not allowed in this resource group. Use this link to
        learn more:
        https://aka.ms/app-service-plan-scale-not-allowed"}}],"Innererror":null}
--- FAIL: TestAccLinuxWebApp_requiresImport (105.96s)
FAIL

@xiaxyi
Copy link
Contributor Author

xiaxyi commented Mar 6, 2024

Thanks @katbyte for the review, tests are good
image

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaxyi - This LGTM 👍

@jackofallops
Copy link
Member

Tests look good:

image

@jackofallops jackofallops dismissed katbyte’s stale review March 11, 2024 07:01

Test failure due to service, not PR change.

@jackofallops jackofallops merged commit 7367b6e into hashicorp:main Mar 11, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.96.0 milestone Mar 11, 2024
jackofallops added a commit that referenced this pull request Mar 11, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Mar 18, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.95.0&#34; to &#34;3.96.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.96.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.96.0&#xA;ENHANCEMENTS:&#xD;&#xA;&#xD;&#xA;*
dependencies: updating to `v0.20240314.1083835` of
`github.com/hashicorp/go-azure-sdk`
([#25255](https://github.com/hashicorp/terraform-provider-azurerm/issues/25255))&#xD;&#xA;*
dependencies: updating to `v0.25.1` of
`github.com/tombuildsstuff/giovanni`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
dependencies: updating to `v1.33.0` of `google.golang.org/protobuf`
([#25243](https://github.com/hashicorp/terraform-provider-azurerm/issues/25243))&#xD;&#xA;*
`storage`: updating the data plane resources to use the transport layer
from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
Data Source: `azurerm_storage_table_entities` - support for AAD
authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
Data Source: `azurerm_storage_table_entity` - support for AAD
authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_kusto_cluster` - support `None` pattern for the
`virtual_network_configuration` block
([#24733](https://github.com/hashicorp/terraform-provider-azurerm/issues/24733))&#xD;&#xA;*
`azurerm_linux_function_app` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_linux_function_app_slot` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_stack_hci_cluster` - support the `identity`, `cloud_id`,
`service_endpoint` and `resource_provider_object_id` properties
[GH-25031]&#xD;&#xA;* `azurerm_storage_share_file` - support for AAD
authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_storage_share_directory` - support for AAD authentication,
deprecate `share_name` and `storage_account_name` in favor of
`storage_share_id`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_storage_table_entity` - support for AAD authentication,
deprecate `share_name` and `storage_account_name` in favor of
`storage_table_id`
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_storage_table_entity` - support for AAD authentication
([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))&#xD;&#xA;*
`azurerm_windows_function_app` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_windows_function_app_slot` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_windows_web_app` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;*
`azurerm_windows_web_app_slot` - support for the Node `20` runtime
([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))&#xD;&#xA;&#xD;&#xA;BUG
FIXES:&#xD;&#xA;&#xD;&#xA;* `azurerm_container_app_custom_domain` - fix
resource ID parsing bug preventing import
([#25192](https://github.com/hashicorp/terraform-provider-azurerm/issues/25192))&#xD;&#xA;*
`azurerm_windows_web_app` - fix incorrect warning message when checking
name availability
([#25214](https://github.com/hashicorp/terraform-provider-azurerm/issues/25214))&#xD;&#xA;*
`azurerm_virtual_machine_run_command` - prevent a bug during updates
([#25186](https://github.com/hashicorp/terraform-provider-azurerm/issues/25186))&#xD;&#xA;*
Data Source: `azurerm_storage_table_entities` - Fix `items.x.properties`
truncating to one entry
([#25211](https://github.com/hashicorp/terraform-provider-azurerm/issues/25211))</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/52/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants