Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for vmTemplate in azurerm_virtual_desktop_host_pool #24358

Closed
1 task done
DevopsMercenary opened this issue Dec 29, 2023 · 3 comments · Fixed by #24369
Closed
1 task done

Support for vmTemplate in azurerm_virtual_desktop_host_pool #24358

DevopsMercenary opened this issue Dec 29, 2023 · 3 comments · Fixed by #24369
Labels
enhancement service/virtual-desktops
Milestone
v3.92.0

Comments

@DevopsMercenary
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

There doesn't appear to be support for vmTemplate property in a azurerm_virtual_desktop_host_pool

Allows the host pool to create VMs dynamically during ramp up.

Some Details...

https://learn.microsoft.com/en-us/rest/api/desktopvirtualization/host-pools/get?view=rest-desktopvirtualization-2022-02-10-preview&tabs=HTTP

image

New or Affected Resource(s)/Data Source(s)

azurerm_virtual_desktop_host_pool

Potential Terraform Configuration

No response

References

No response
harshavmb added a commit to AmadeusITGroup/terraform-provider-azurerm that referenced this issue Jan 2, 2024
@harshavmb
hashicorp#24358: Support vmTemplate for azurerm_virtual_desktop_host_…
f66008a 
…pool resource
@harshavmb harshavmb mentioned this issue Jan 2, 2024
Merged
@rcskosir
Copy link
Contributor

rcskosir commented Jan 8, 2024 •
edited

Thank you for taking the time to open this issue. Please subscribe to PR #24369 for this issue.

harshavmb added a commit to AmadeusITGroup/terraform-provider-azurerm that referenced this issue Jan 10, 2024
@harshavmb
hashicorp#24358: Changes as per review comments
f27d4ae
harshavmb added a commit to AmadeusITGroup/terraform-provider-azurerm that referenced this issue Jan 10, 2024
@harshavmb
hashicorp#24358: Fix error
222f70b
@harshavmb
Copy link
Contributor

Hi @DevopsMercenary ,

Do you have a sample vmTemplate you could share here? Apparently I couldn't find documentation. This is for adding a test case for this change.

harshavmb added a commit to AmadeusITGroup/terraform-provider-azurerm that referenced this issue Feb 13, 2024
@harshavmb
hashicorp#24358: Adding testcase for vm_template
011433a
katbyte pushed a commit that referenced this issue Feb 16, 2024
@harshavmb
#24358: Support vm_template for azurerm_virtual_desktop_host_pool res…
f72bb19 
…ource (#24369)

* #24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource

* #24358: Changes as per review comments

* #24358: Fix error

* #24358: Adding testcase for vm_template
@github-actions github-actions bot added this to the v3.92.0 milestone Feb 16, 2024
@jenka13all jenka13all mentioned this issue Feb 20, 2024
Open
1 task
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this issue Feb 21, 2024
@harshavmb @rizkybiz
hashicorp#24358: Support vm_template for azurerm_virtual_desktop_host…
0a819f3 
…_pool resource (hashicorp#24369)

* hashicorp#24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource

* hashicorp#24358: Changes as per review comments

* hashicorp#24358: Fix error

* hashicorp#24358: Adding testcase for vm_template
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this issue Feb 29, 2024
@harshavmb @rizkybiz
hashicorp#24358: Support vm_template for azurerm_virtual_desktop_host…
b3654e2 
…_pool resource (hashicorp#24369)

* hashicorp#24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource

* hashicorp#24358: Changes as per review comments

* hashicorp#24358: Fix error

* hashicorp#24358: Adding testcase for vm_template
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement service/virtual-desktops
Projects
None yet
Milestone
v3.92.0
4 participants
@harshavmb @mybayern1974 @DevopsMercenary @rcskosir